Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vkBasalt #9834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

liberodark
Copy link

@liberodark liberodark commented Sep 10, 2023

Build OK

@liberodark liberodark force-pushed the vkbalsalt branch 12 times, most recently from 94ad462 to 8d1a228 Compare September 10, 2023 19:53
@liberodark liberodark marked this pull request as ready for review September 10, 2023 19:53
@dmanlfc
Copy link
Collaborator

dmanlfc commented Sep 11, 2023

I don't think this is a good idea for v38, but probably beyond

  1. The developer has given up on the project
  2. This adds a layer of complexity to Wine which is already bugged.
  3. The current implementation allows for vkbasalt when potentially running OpenGL games.
  4. There is no configuration options for the conf file / shaders etc.

Do we really need it??? It will be another layer in Vulkan to manage ...

@liberodark
Copy link
Author

VKBasalt works very well I don't see the problem.
Why not add it? There is a default configuration which is already very good and which allows for interesting use.
This does not add any complexity to wine.
The project is still in development, in fact it is alone.
The current wine bugs are mainly linked to a system that does not manage multilib.
But otherwise I don't see any reason not to add it, it adds an interesting feature to Wine for users.

@Redemp
Copy link

Redemp commented Sep 22, 2023

VKBasalt works very well I don't see the problem. Why not add it? There is a default configuration which is already very good and which allows for interesting use. This does not add any complexity to wine. The project is still in development, in fact it is alone. The current wine bugs are mainly linked to a system that does not manage multilib. But otherwise I don't see any reason not to add it, it adds an interesting feature to Wine for users.

I'm backing you up here. Not only can we use reshade ported shaders but this could potentially be used not only on Wine but anything that uses Vulcan.

I have already talked a few weeks ago to one of the devs over at the reshade discord server about porting the libretro Image-adjustment shader over to reshade. This could potentially mean we could use the shader for GunCon2 on a lot more then just wine.

Quite a big game changer 😎

Edit:
Just look at all the cool Retroarch shades ported here
https://github.com/Matsilagi/RSRetroArch

@Redemp
Copy link

Redemp commented Dec 12, 2023

Any updates on this?

@Tovarichtch
Copy link
Collaborator

Any update on this? This is required to bring the white border for Sinden Lightgun using ReShade (Vulkan only). I don't see any better solution than that.

@aderumier
Copy link

Hi,I'm also looking for this to add sinden lightgun white border with reshade

@Redemp
Copy link

Redemp commented Apr 18, 2024

This should make things much easier to integrate
vkbasalt-cli (filename vkbasalt) is a CLI utility and library in conjunction with vkBasalt. This makes generating configuration files or running vkBasalt with games easier. This is mainly convenient in environments where integrating vkBasalt is wishful, for example a GUI application. Integrating vkbasalt-cli allows a front-end to easily generate and use specific configurations on the fly, without asking the user to manually write a configuration file.

https://pypi.org/project/vkbasalt-cli/

@dmanlfc
Copy link
Collaborator

dmanlfc commented Apr 20, 2024

cli is not needed @Redemp as it can be done with a conf file & configgen.

as per my previous points

  1. The current implementation allows for vkbasalt when potentially running OpenGL games.
  2. There is no configuration options for the conf file / shaders etc.

@Redemp
Copy link

Redemp commented Apr 29, 2024

cli is not needed @Redemp as it can be done with a conf file & configgen.

as per my previous points

  1. The current implementation allows for vkbasalt when potentially running OpenGL games.
  2. There is no configuration options for the conf file / shaders etc.

I was unaware that it actually worked with OpenGL.
From my understanding it only works with dxvk and vkd3d
Will there be a openGl version?
But I have been very successful in using Gamescope and then it works without issues.
But sadly that pr 5610 was closed. So I have to resort to calling a build of Gamescope I shoe horned myself into Batocera.

If conf file needs to be made I will be more then happy to put in the work for exposing the setting for them in whatever manner you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants