Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squished/narrow image when capturing new document. #31

Closed
CorneliousJD opened this issue Dec 28, 2020 · 6 comments
Closed

Squished/narrow image when capturing new document. #31

CorneliousJD opened this issue Dec 28, 2020 · 6 comments
Labels
android bug Something isn't working scanner

Comments

@CorneliousJD
Copy link

This was the result of the Google app store review where you asked me to submit the issue.

Here's an example photo, along with a screenshot for how squished it looks in the app.
Note that once I select the bounding box around the document and actually OK it, the dimensions are corrected.

ACTUAL:
image

APP:
image

@bauerj bauerj added bug Something isn't working android scanner labels Dec 28, 2020
@bauerj
Copy link
Owner

bauerj commented Dec 28, 2020

Thanks for your screenshots.

Sadly the upstream library that contains this bug (https://github.com/sawankumarbundelkhandi/edge_detection) seems to be unmaintained. However, there are two outstanding pull requests, one of which seems to fix this issue (and also the annoying issue with the triangle you are seeing).

I will merge both PRs into my fork and see if this helps.

@CorneliousJD
Copy link
Author

Sounds good - overall it works just fine - the weird triangle also fixes itself when sitting on the doc long enough, more of a visual glitch than a usability one, but if you need any help testing let me know, thanks!

@bauerj
Copy link
Owner

bauerj commented Dec 28, 2020

Okay, my build environment broke for no apparent reason but now I have a version with the changes integrated:
https://bauerj.eu/app-arm64-v8a-release.apk

Can you try this release candidate and see if it fixes the issue?

@CorneliousJD
Copy link
Author

Tested. That seems to work! I do still get the weird triangle bounding box sometimes but it wasn't ever much of an issue before either. :)

No more squish thought! Thanks!

@bauerj
Copy link
Owner

bauerj commented Dec 28, 2020

Wow, that was quick! I'm glad it works now.

Thanks a lot to @vmwsree and @tiagosito for your work on the edge detection library!

I will release an update with all the improvements to the scanner soon.

bauerj added a commit that referenced this issue Dec 29, 2020
@bauerj
Copy link
Owner

bauerj commented Dec 29, 2020

Okay, this is fixed in 0.0.10 which should be available through Google Play on Wednesday.

@bauerj bauerj closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something isn't working scanner
Projects
None yet
Development

No branches or pull requests

2 participants