2007-12-04 Marek Safar <marek.safar@gmail.com>

A fix for regression #345467 * typemanager.cs: Fixed type arguments comparison. svn path=/branches/mono-1-2-6/mcs/; revision=90718
baulig · Dec 4, 2007 · 6b846e4 · 6b846e4
1 parent f9db162
commit 6b846e4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/mcs/mcs/ChangeLog b/mcs/mcs/ChangeLog
@@ -1,3 +1,8 @@
+2007-12-04  Marek Safar  <marek.safar@gmail.com>
+
+	A fix for regression #345467
+ 	* typemanager.cs: Fixed type arguments comparison.
+
 2007-11-28  Marek Safar  <marek.safar@gmail.com>
 
  	* expression.cs (BaseAccess): Type arguments can be null.

diff --git a/mcs/mcs/typemanager.cs b/mcs/mcs/typemanager.cs
@@ -2836,9 +2836,10 @@ public static bool IsEqual (Type a, Type b)
 
 #if GMCS_SOURCE
 		if (a.IsGenericParameter && b.IsGenericParameter) {
-			if (a.DeclaringMethod != b.DeclaringMethod &&
-			    (a.DeclaringMethod == null || b.DeclaringMethod == null))
-				return false;
+			// TODO: needs more testing before cleaning up
+			//if (a.DeclaringMethod != b.DeclaringMethod &&
+			//    (a.DeclaringMethod == null || b.DeclaringMethod == null))
+			//	return false;
 			return a.GenericParameterPosition == b.GenericParameterPosition;
 		}