Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggle between freespace/100/fit-to-screen issue #746

Closed
dericed opened this issue May 7, 2023 · 3 comments
Closed

toggle between freespace/100/fit-to-screen issue #746

dericed opened this issue May 7, 2023 · 3 comments
Assignees

Comments

@dericed
Copy link
Member

dericed commented May 7, 2023

This is a clean build on #735 with qt 5.15.8. In the video there's two issues, when I first select to enable the waveform (in free scale mode), which should make the image bigger, the image suddenly reduces in size even though the output should be with no scaling change. Later when changing from 100% to fit to screen, the image does not fit to screen but is a smaller size.
freescale

sample video is ffmpeg -f lavfi -i testsrc2 -t 10 yuv422p.mkv

ElderOrb added a commit to ElderOrb/qctools that referenced this issue May 7, 2023
@ElderOrb
Copy link
Collaborator

ElderOrb commented May 7, 2023

@dericed please recheck

@dericed
Copy link
Member Author

dericed commented May 8, 2023

The update works well. Thank you.
One remaining issue. When I first open the video in the player and change from Fit-to-screen to Free-Scale the zoom slider is set to 0% (which doesn't make sense, default should be 100%). Slider should be in a range of 50% to 200%, so not 0.

@ElderOrb
Copy link
Collaborator

@dericed ^^

@dericed dericed closed this as completed May 13, 2023
g-maxime pushed a commit to g-maxime/qctools that referenced this issue Aug 28, 2023
g-maxime pushed a commit to g-maxime/qctools that referenced this issue Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants