Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using QtAVPlayer for stats parsing & thumbnails/panels generation #735

Merged
merged 59 commits into from
May 12, 2023

Conversation

ElderOrb
Copy link
Collaborator

No description provided.

@@ -1,5 +1,5 @@
QT += core network
QT -= gui
QT += core gui multimedia network
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we avoid to require GUI stuff for the CLI package?
It may create problems on servers without GUI support, either lack of QtGUI packages and/or company policy forbidding to install a X server..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully one day - yes, although it will require some support from QtAVPlayer side. For now need to finish migration and get something working.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should QtGUI be avoided at all? QtAVPlayer requires to have QtGUI to use some features like opengl, 'egl', also to negotiate platform and choose right codec.

Copy link
Contributor

@JeromeMartinez JeromeMartinez Apr 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a preference, in order to avoid to pull all GUI stuff on a server without GUI, but only if it is easy to do, I expected that all non GUI stuff related to GPU i.e. codec choice is not linked to QtGUI, but if it is currently the case we can keep QtGUI for CLI up to someone motivated enough for sponsoring the removal of this binding if it is a big issue for the person.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removing QtGUI dependency at all.

@ElderOrb ElderOrb force-pushed the replace_ffmpeg_glue branch 3 times, most recently from d51d41d to 66bbc8d Compare April 11, 2023 10:35
@ElderOrb ElderOrb force-pushed the replace_ffmpeg_glue branch 4 times, most recently from cf5b8b7 to 5b94b95 Compare April 11, 2023 23:21
@ElderOrb ElderOrb changed the title [WIP] using QtAVPlayer for stats parsing & thumbnails/panels generation using QtAVPlayer for stats parsing & thumbnails/panels generation May 11, 2023
@dericed dericed merged commit d6fba6e into bavc:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants