-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using QtAVPlayer for stats parsing & thumbnails/panels generation #735
Conversation
@@ -1,5 +1,5 @@ | |||
QT += core network | |||
QT -= gui | |||
QT += core gui multimedia network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we avoid to require GUI stuff for the CLI package?
It may create problems on servers without GUI support, either lack of QtGUI packages and/or company policy forbidding to install a X server..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully one day - yes, although it will require some support from QtAVPlayer side. For now need to finish migration and get something working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should QtGUI be avoided at all? QtAVPlayer requires to have QtGUI to use some features like opengl
, 'egl', also to negotiate platform and choose right codec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a preference, in order to avoid to pull all GUI stuff on a server without GUI, but only if it is easy to do, I expected that all non GUI stuff related to GPU i.e. codec choice is not linked to QtGUI, but if it is currently the case we can keep QtGUI for CLI up to someone motivated enough for sponsoring the removal of this binding if it is a big issue for the person.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, removing QtGUI dependency at all.
47d2df7
to
bc6531d
Compare
c61b3e9
to
bdf5a3a
Compare
d51d41d
to
66bbc8d
Compare
cf5b8b7
to
5b94b95
Compare
5b94b95
to
384554d
Compare
4fcb0d7
to
71dda03
Compare
…epping / seeking in progress
No description provided.