[9.6] Event Architecture #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
96ed176
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://26154ae0.laravel-wallet.pages.dev |
| Branch Preview URL: | https://event-architecture.laravel-wallet.pages.dev |
rez1dent3
force-pushed
the
event-architecture
branch
from
6dd720c
to
2c62c78
Compare
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 511 528 +17
===========================================
Files 77 83 +6
Lines 1576 1606 +30
===========================================
+ Hits 1576 1606 +30
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The implementation is blocked by the framework. The committing event is missing. |
|
The lock is released, the event has appeared in the framework. PR needs to be improved. |
rez1dent3
force-pushed
the
event-architecture
branch
from
2c62c78
to
696dbb7
Compare
This was
linked to
issues
Oct 19, 2022
Closed
rez1dent3
force-pushed
the
event-architecture
branch
from
3a67102
to
267e5b1
Compare
rez1dent3
force-pushed
the
event-architecture
branch
from
87f81a0
to
3584c5a
Compare
|
I will have to pull classes in events from app(). The octane issue will most likely go away. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the new functionality in the laravel framework (adding a committing event), it became possible to solve all the old problems of the package. And this is full support for laravel nova. The package actively helps you deal with the race condition. Before version 9.6, only with the help of AtomicServiceInterface it was possible to block the wallet for the duration of useful work, and later apply or roll back the transaction, but now the package implements lazy locks. When you work with the wallet API, your wallet is blocked until the commit/rollback operation.
The most important change is the check for the start of a transaction has been removed. Inside the package, I completely abandoned the custom solution for creating transactions.
Do not forget about the internal state, it is available exclusively in the AtomicServiceInterface. Those, the introduction of lazy locks does not negate the benefits of atomics. You can read more here: #562