Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: DB::rollBack(0) in nova action prevents actionable trait to works #569

Closed
ibrunotome opened this issue Sep 13, 2022 · 4 comments · Fixed by #589
Closed

bug: DB::rollBack(0) in nova action prevents actionable trait to works #569

ibrunotome opened this issue Sep 13, 2022 · 4 comments · Fixed by #589
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@ibrunotome
Copy link

Describe the bug
There is a Actionable trait that logs all actions that ran before

https://nova.laravel.com/docs/4.0/actions/defining-actions.html#action-log

Screen Shot 2022-09-13 at 11 48 40

But using the solution https://bavix.github.io/laravel-wallet/#/nova-action, these action logs will not be recorded

Server:

  • php version: 8.1
  • database: postgres 14.0
  • wallet version 9.3
  • cache lock: redis
  • cache wallets: redis
@ibrunotome ibrunotome added bug Something isn't working question Further information is requested labels Sep 13, 2022
@rez1dent3
Copy link
Member

@ibrunotome Thank you. I have never used this functionality. In the near future we will have to see what can be done there. At the moment, there are no ideas.

@rez1dent3
Copy link
Member

@ibrunotome Hello. Taylor accepted my PR and soon I will try to solve this problem and completely abandon my own DatabaseServiceInterface in favor of a standard solution.

But there will definitely not be a release in the near future, because. the changes are too big and you need to make sure that it works correctly.

Now you can take the event-architecture branch and see if your problem is gone.

PS. Changes to illuminate/database are still without a tag, so Laravel must be installed with the 9.x branch...

@rez1dent3
Copy link
Member

@ibrunotome Hello. Tag 9.6.0.

@ibrunotome
Copy link
Author

You're a great developer @rez1dent3, thank you for always being improving this package.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants