Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also check dev dependencies. #15

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Also check dev dependencies. #15

merged 1 commit into from
Sep 9, 2020

Conversation

zozoens31
Copy link
Contributor

@zozoens31 zozoens31 commented Sep 8, 2020 •
edited by pcorpet
Loading

This change is Reviewable

pcorpet
pcorpet approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@pcorpet pcorpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@zozoens31 zozoens31 merged commit 3f681fa into master Sep 9, 2020
@zozoens31 zozoens31 deleted the cyrille-keep-dev-dependencies branch September 9, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcorpet pcorpet pcorpet approved these changes

Assignees

@pcorpet pcorpet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zozoens31 @pcorpet