-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
…ation, UI not included
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also make sure to include line feeds at the end @baymac
You mean a new line at the end of file, right? Why is it required btw? |
It is not required but rather a stylistic request |
That is a good convention carried through Linux: https://thoughtbot.com/blog/no-newline-at-end-of-file You can use checkstyle to check for these: https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/.mvn/checkstyle.xml |
For some reason the Authentication Token generated from Auth Class and Personal Token is null. |
This reverts commit 41a5252.
@markyjackson-taulia I will add all the necessary changes in the next commit. After that we merge this Pr. |
src/main/java/io/jenkins/plugins/gitlabbranchsource/client/api/GitLabAuth.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/credentials/PersonalAccessToken.java
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/credentials/PersonalAccessToken.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/credentials/PersonalAccessTokenImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/credentials/PersonalAccessTokenImpl.java
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/credentials/PersonalAccessTokenImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/credentials/PersonalAccessTokenImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/servers/GitLabServer.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/servers/GitLabServer.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/servers/GitLabServer.java
Show resolved
Hide resolved
This pull request is ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Implementation of GitLab Server Configuration in Jenkins Global Configuration.
Inspired mostly from Gitea plugin and a few things from GitHub Plugin.
Uses GitLab API Plugin for server authentication.