Skip to content
This repository has been archived by the owner on Aug 3, 2019. It is now read-only.

Feature/add auth #1

Merged
merged 48 commits into from
May 31, 2019
Merged

Feature/add auth #1

merged 48 commits into from
May 31, 2019

Conversation

baymac
Copy link
Owner

@baymac baymac commented May 25, 2019

Implementation of GitLab Server Configuration in Jenkins Global Configuration.

Inspired mostly from Gitea plugin and a few things from GitHub Plugin.

Uses GitLab API Plugin for server authentication.

gitlabbranchsource.iml Outdated Show resolved Hide resolved
Copy link
Collaborator

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make sure to include line feeds at the end @baymac

@baymac
Copy link
Owner Author

baymac commented May 25, 2019

Please also make sure to include line feeds at the end @baymac

You mean a new line at the end of file, right? Why is it required btw?

@markjacksonfishing
Copy link
Collaborator

Please also make sure to include line feeds at the end @baymac

You mean a new line at the end of file, right? Why is it required btw?

It is not required but rather a stylistic request

@jetersen
Copy link
Contributor

jetersen commented May 25, 2019

Please also make sure to include line feeds at the end @baymac

You mean a new line at the end of file, right? Why is it required btw?

That is a good convention carried through Linux: https://thoughtbot.com/blog/no-newline-at-end-of-file

You can use checkstyle to check for these: https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/.mvn/checkstyle.xml

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@LinuxSuRen
Copy link
Collaborator

image

This button is not working.

@baymac
Copy link
Owner Author

baymac commented May 27, 2019

For some reason the Authentication Token generated from Auth Class and Personal Token is null.

@baymac
Copy link
Owner Author

baymac commented May 31, 2019

@markyjackson-taulia I will add all the necessary changes in the next commit. After that we merge this Pr.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@baymac baymac removed the Do Not Merge Wait for the removal of this label to merge label May 31, 2019
@baymac
Copy link
Owner Author

baymac commented May 31, 2019

This pull request is ready to be merged.

Copy link
Collaborator

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@jeffpearce jeffpearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@baymac baymac marked this pull request as ready for review May 31, 2019 17:06
Repository owner deleted a comment from LinuxSuRen May 31, 2019
@baymac baymac merged commit aff6a78 into develop May 31, 2019
@baymac baymac deleted the feature/add-auth branch May 31, 2019 18:26
@baymac baymac removed their assignment Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants