Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of GitHub actions cache #35

Merged
merged 1 commit into from Dec 26, 2022

Conversation

pziggo
Copy link
Contributor

@pziggo pziggo commented Nov 16, 2022

Using quotes for the items in path does not resolve ~ correctly and
thus leads to the following warning in the post section:

Warning: Path Validation Error: Path(s) specified in the action for
caching do(es) not exist, hence no cache is being saved.

Using quotes for the items in path does not resolve `~` correctly and
thus leads to the following warning in the post section:

```
Warning: Path Validation Error: Path(s) specified in the action for
caching do(es) not exist, hence no cache is being saved.
```
@dastbe
Copy link

dastbe commented Dec 26, 2022

So it's actually because of how vertical bars vs. basic strings work.

testing these two files

test: "one"

vs

test: |
  "one"

here is the value of the the test key respectively:

# simple string
'one'

# pipe
'"one"\n'

Github will process these lines literally, hence why the quotes are confusing.

Copy link
Contributor

@kormide kormide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Sorry that this slipped my radar.

@kormide kormide merged commit 2c359ab into bazel-contrib:main Dec 26, 2022
@pziggo pziggo deleted the pziggo_fix_ci_cache branch December 27, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants