Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript): fix for cross platform ts_devserver issue #1409 #1413

Merged
merged 1 commit into from
Dec 4, 2019
Merged

fix(typescript): fix for cross platform ts_devserver issue #1409 #1413

merged 1 commit into from
Dec 4, 2019

Commits on Dec 3, 2019

  1. fix(typescript): fix for cross platform ts_devserver issue bazel-cont… 

    …rib#1409

This change allows a ts_devserver target to be build with cross platform RBE (host platform is osx or Windows & execution platform is linux) and still run on the host platform.

With cross-platform RBE for OSX & Windows ctx.executable.devserver will be linux as --cpu and --host_cpu must be overridden to k8. However, we still want to be able to run the devserver on the host machine so we need to include the host devserver binary, which is ctx.executable.devserver_host, in the runfiles. For non-RBE and for RBE with a linux host, ctx.executable.devserver & ctx.executable.devserver_host will be the same binary.
    @gregmagolan
    gregmagolan committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    01e769c View commit details
    Browse the repository at this point in the history