Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oci_push --repository and --repotags flags should accept file paths #46

Closed
thesayyn opened this issue Jan 11, 2023 · 4 comments
Closed

oci_push --repository and --repotags flags should accept file paths #46

thesayyn opened this issue Jan 11, 2023 · 4 comments
Assignees
@alexeagle
Milestone
1.0

Comments

@thesayyn
Copy link
Collaborator

thesayyn commented Jan 11, 2023 •
edited by alexeagle
Loading

Useful for stamping, for example
@thesayyn thesayyn added this to the 1.0 milestone Jan 13, 2023
@alexeagle
Copy link
Collaborator

already changed repotags to take a file argument

@alexeagle alexeagle mentioned this issue Mar 31, 2023
Closed
@alexeagle alexeagle self-assigned this Apr 13, 2023
alexeagle added a commit that referenced this issue Apr 13, 2023
@alexeagle
feat: allow stamping in repository name
70db155 
This could be used to take the username of the person running the build.

Fixes #46
alexeagle added a commit that referenced this issue Apr 13, 2023
@alexeagle
feat: allow stamping in repository name
71d896a 
This could be used to take the username of the person running the build.

Fixes #46
alexeagle added a commit that referenced this issue Apr 13, 2023
@alexeagle
feat: allow stamping in repository name
b39919a 
This could be used to take the username of the person running the build.

Fixes #46
@alexeagle alexeagle mentioned this issue Apr 13, 2023
Closed
@thesayyn thesayyn changed the title oci_push --repository and --tag flags should accept file paths oci_push --repository and --repotags flags should accept file paths Apr 14, 2023
@thesayyn
Copy link
Collaborator Author

closing this as we already support stamped repotags

@malt3 malt3 mentioned this issue Jun 12, 2023
Open
@seh
Copy link
Contributor

seh commented Sep 13, 2023

Now that the repository name is back out of the "remote_tags" attribute and in its own "repository" attribute, we lost this ability that we had for a brief while.

The discussion here sounds like the maintainers were convinced of the value of stamping the repository name, but since then we've wavered on which information gets conveyed in which attribute values. Yes, if we could convey the repository name in the stamp-friendly "remote_tags" attribute, this need would be covered, but with the separate "repository" attribute we have today, I think there's still an open gap.

@seh
Copy link
Contributor

seh commented Sep 14, 2023

See #338 for taking the repository from the content of a file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeagle alexeagle

Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

feat: allow stamping in repository name bazel-contrib/rules_oci
3 participants
@alexeagle @seh @thesayyn