Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oci_image should support adding labels #47

Closed
thesayyn opened this issue Jan 11, 2023 · 2 comments · Fixed by #76
Closed

oci_image should support adding labels #47

thesayyn opened this issue Jan 11, 2023 · 2 comments · Fixed by #76
Milestone
1.0

Comments

@thesayyn
Copy link
Collaborator

No description provided.

@thesayyn thesayyn added this to the 1.0 milestone Jan 13, 2023
@psalaberria002
Copy link
Contributor

Any ideas for how to implement this? From a quick look at crane, it only supports mutating images that are already in a registry?

@thesayyn
Copy link
Collaborator Author

we already spin a local registry at a random port. this should be already feasible we just need to introduce a new attribute and pass it to crane mutate via --label like we do for --env

psalaberria002 added a commit to psalaberria002/rules_oci that referenced this issue Feb 24, 2023
@psalaberria002
Add labels to oci_image
c531951 
Fixes bazel-contrib#47
psalaberria002 added a commit to psalaberria002/rules_oci that referenced this issue Feb 24, 2023
@psalaberria002
Add labels to oci_image
457efe0 
Fixes bazel-contrib#47
psalaberria002 added a commit to psalaberria002/rules_oci that referenced this issue Feb 24, 2023
@psalaberria002
Add labels to oci_image
a46bb64 
Fixes bazel-contrib#47
psalaberria002 added a commit to psalaberria002/rules_oci that referenced this issue Feb 24, 2023
@psalaberria002
Add labels to oci_image
e23ddf0 
Fixes bazel-contrib#47

Signed-off-by: psalaberria002 <psalaberria002@gmail.com>
@psalaberria002 psalaberria002 mentioned this issue Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Add labels to oci_image psalaberria002/rules_oci
2 participants
@psalaberria002 @thesayyn