Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BCR presubmit on windows #97

Open
alexeagle opened this issue Mar 13, 2023 · 6 comments · Fixed by #98 · May be fixed by #307
Open

Fix BCR presubmit on windows #97

alexeagle opened this issue Mar 13, 2023 · 6 comments · Fixed by #98 · May be fixed by #307
Labels
cleanup Address tech debt

Comments

@alexeagle
Copy link
Collaborator

@alexeagle
Copy link
Collaborator Author

not fixed: https://buildkite.com/bazel/bcr-presubmit/builds/1126#0186dd9f-cbff-4f73-8cfb-d6d96ffa913f
and this is difficult because https://github.com/project-zot/zot/releases doesn't have any windows binaries?

@alexeagle
Copy link
Collaborator Author

@thesayyn could we just not register a zot toolchain in the e2e/smoke? then Windows could be green?

@thesayyn
Copy link
Collaborator

not really if we really want it to be a simple smoke test where we assert registry and oci_image works.

@alexeagle
Copy link
Collaborator Author

Seems like there's another Windows bug separate from the above:

Screenshot 2023-07-17 at 11 55 28 AM

@alexeagle
Copy link
Collaborator Author

Update, I think I have fixed all the bugs! Now just waiting on a release of https://github.com/GoogleContainerTools/container-structure-test which @loosebazooka hopes to get to today.

alexeagle added a commit that referenced this issue Aug 2, 2023
alexeagle added a commit that referenced this issue Aug 2, 2023
@alexeagle alexeagle linked a pull request Aug 2, 2023 that will close this issue
@alexeagle
Copy link
Collaborator Author

With everything put together now, #307 makes it green for me locally on Windows, but I'm struggling with the CI failure on that PR.

@thesayyn thesayyn added the cleanup Address tech debt label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Address tech debt
Projects
None yet
2 participants