Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add windows coverage #307

Closed
wants to merge 2 commits into from
Closed

ci: add windows coverage #307

wants to merge 2 commits into from

Conversation

alexeagle
Copy link
Collaborator

@alexeagle alexeagle commented Jul 21, 2023

Fixes #97

@alexeagle
Copy link
Collaborator Author

Ugh! I can't reproduce this windows failure locally, even with
bazel clean --expunge; bazel --bazelrc=../../.github/workflows/ci.bazelrc --bazelrc=.bazelrc test --enable_bzlmod --noenable_runfiles //... --nocache_test_results
it is still green for me. That spot that passes the $(rlocation) for tarball.tar so the test failure isn't making sense. I'll come back to it later maybe.

@alexeagle
Copy link
Collaborator Author

@thesayyn this failure doesn't make sense to me from looking at the code, do you have any ideas?

@thesayyn
Copy link
Collaborator

@thesayyn this failure doesn't make sense to me from looking at the code, do you have any ideas?

it might repro if you delete docker.config at $HOME. Also it might help if you rebase as i am not sure if this branch was run against the main that has some fixes for docker config discovery.

@thesayyn thesayyn force-pushed the windows4 branch 2 times, most recently from e05ef37 to 7c593bd Compare June 8, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix BCR presubmit on windows
2 participants