Propagate transitive ObjC and Swift copts #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohmcruz
requested review from
jszumski,
jerrymarino,
mattrobmattrob,
luispadron and
congt
congt
approved these changes
May 31, 2023
luispadron
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifying if indexing continues to work on Xcode 14.3 and noticed that there's a better fix for an indexing issue I fixed recently.
_target_is_mixedcheck as the intent was to conditionally set-import-underlying-moduleto workaround an indexing issuecoptsthis PR adds are enough to fix the same indexing issue I found at the time when_target_is_mixedwas introduced as part of Fixes for indexing in Xcode 14.x #661