Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNR][HOLD] Make symbol_graph optional #736

Closed
wants to merge 1 commit into from
Closed

[DNR][HOLD] Make symbol_graph optional #736

wants to merge 1 commit into from

Conversation

thiagohmcruz
Copy link
Contributor

For those on old rules_swift SHAs symbol_graph does not exist. This PR makes it "optional" to trigger the behaviour introduced in #734.

@thiagohmcruz thiagohmcruz marked this pull request as ready for review July 18, 2023 14:37
@thiagohmcruz thiagohmcruz requested review from jerrymarino and luispadron and removed request for jerrymarino and luispadron July 18, 2023 14:38
@thiagohmcruz
Copy link
Contributor Author

Actually hold, we might not want this.

@thiagohmcruz thiagohmcruz changed the title Make symbol_graph optional [DNR][HOLD] Make symbol_graph optional Jul 18, 2023
@thiagohmcruz thiagohmcruz marked this pull request as draft July 18, 2023 14:50
@thiagohmcruz thiagohmcruz deleted the thiago/make-symbol_graph-optional branch July 18, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thiagohmcruz