Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not declare force_load and VFS targets unnecessarily #858

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

thiagohmcruz
Copy link
Contributor

@thiagohmcruz thiagohmcruz commented Apr 1, 2024

Saves analysis time since it implies less rules impls to go through and less configured targets to process

@luispadron luispadron changed the title Do not declare targets unnecessarily Do not declare force_load targets unnecessarily Apr 1, 2024
@thiagohmcruz thiagohmcruz changed the title Do not declare force_load targets unnecessarily Do not declare force_load and VFS targets unnecessarily Apr 1, 2024
@thiagohmcruz thiagohmcruz force-pushed the thiago/do-not-declare-targets-unnecessarily branch 5 times, most recently from b9a95db to 5064bd6 Compare April 4, 2024 15:50
@thiagohmcruz thiagohmcruz marked this pull request as ready for review April 4, 2024 16:23
Copy link
Collaborator

@luispadron luispadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thank you!

rules/library.bzl Outdated Show resolved Hide resolved
@thiagohmcruz thiagohmcruz force-pushed the thiago/do-not-declare-targets-unnecessarily branch from 5064bd6 to 9abd595 Compare April 4, 2024 16:28
@thiagohmcruz thiagohmcruz enabled auto-merge (squash) April 4, 2024 16:31
@thiagohmcruz thiagohmcruz merged commit 5182a71 into master Apr 4, 2024
7 checks passed
@thiagohmcruz thiagohmcruz deleted the thiago/do-not-declare-targets-unnecessarily branch April 4, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants