Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI server. #100

Closed
ttsugriy opened this issue Feb 19, 2018 · 12 comments
Closed

Setup CI server. #100

ttsugriy opened this issue Feb 19, 2018 · 12 comments

Comments

@ttsugriy
Copy link
Contributor

It would be great if there was a Travis CI or Circle CI configured for PRs, so that reviewers can immediately see build and test results.

@werkt
Copy link
Collaborator

werkt commented Feb 19, 2018

The bazelbuild org has a CI instance that we are planning to use. That is currently undergoing an upgrade, and expected ETA within the next couple of weeks.

@werkt
Copy link
Collaborator

werkt commented Feb 20, 2018

I should also note, pull requests are welcome here to get this done. All that needs to be done is to follow instructions at bazelbuild/continuous-integration, and post a pull request to that repository

@ttsugriy
Copy link
Contributor Author

according to documentation repo owners should allow access to robots in order for that CI to work. Could someone please do that? I'll see if I can find some time to send a PR to add buildfarm repo there.

ttsugriy added a commit to ttsugriy/continuous-integration that referenced this issue Feb 20, 2018
Since bazel-buildfarm setup is simple, default config works
great for it.

Fixes bazelbuild/bazel-buildfarm#100
@werkt
Copy link
Collaborator

werkt commented Feb 20, 2018

https://github.com/orgs/bazelbuild/teams/robot (already) has write access to bazel-buildfarm, should be good to go for integration.

@ttsugriy
Copy link
Contributor Author

thanks for checking, @werkt! Hopefully PR will be merged soon.

@buchgr
Copy link
Collaborator

buchgr commented Feb 22, 2018

buildfarm is on our brand new buildkite CI now. I think this can be closed?

@ttsugriy
Copy link
Contributor Author

@buchgr, this issue was created mainly to track external contributor experience, which currently does not exist. For every PR there should be a signal about build and test results.

@werkt
Copy link
Collaborator

werkt commented Feb 22, 2018 via email

@werkt
Copy link
Collaborator

werkt commented Feb 22, 2018 via email

@ttsugriy
Copy link
Contributor Author

oh, sorry, the commit summaries with CI configs were somewhat scare in terms of description, so I didn't realize that they seem to be covering all use cases :) Also, when I clicked on a badge icon, I was greeted with request to create an account, so I'm not sure if everyone can access build results :(

@werkt
Copy link
Collaborator

werkt commented Feb 23, 2018

Doesn't seem like there's any facility for making that link content public, at a minimum we could repoint the markup content...

@werkt
Copy link
Collaborator

werkt commented Jun 13, 2018

Going to call this one closed in spirit, the CI is up and has been working for some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants