Restore DequeueMatchSettings Platform #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DequeueMatchSettings Platform before 0a6802e provided for selection or rejection of queue entries based on locally selectable platform properties that it provides, per worker. The config transition eliminated this capability, and left the workers only with the properties selected from the queue definition restrictions. Highlighting this was the elimination of use of the platform during ShardWorkerContext test creation, leaving a platform parameter orphaned. Use the DMS Platform both in eligibility filtering and selection of the eligible queues to permit mildly heterogenous worker queue processing. Fixes bazelbuild#1350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DequeueMatchSettings Platform before 0a6802e provided for selection or rejection of queue entries based on locally selectable platform properties that it provides, per worker. The config transition eliminated this capability, and left the workers only with the properties selected from the queue definition restrictions. Highlighting this was the elimination of use of the platform during ShardWorkerContext test creation, leaving a platform parameter orphaned.
Use the DMS Platform both in eligibility filtering and selection of the eligible queues to permit mildly heterogenous worker queue processing.
Fixes #1350