Enable prometheus logging for buildfarm:worker read on client cancel #1417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently we don't see any metrics with status
cancelled
for buildfarm:worker read. This issue arises because the onCancelHandler does not invoke theresponseObserver.onError
method. As a result, the reportEndMetrics function, responsible for logging prometheus metrics, is not triggered.Solution
Added code to ensure that the responseObserver.onError method is called when the client initiates a cancellation request. Additionally, added a check in the ServerStreamCallObserver implementation to avoid the call already closed error, which could occur if the buildfarm:worker has already called onComplete or onError (realistically onComplete) by the time the cancellation request from the client (buildfarm:server) arrives.