Add a production-ready helm chart for deploying buildfarm on k8s #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werkt
reviewed
Sep 7, 2023
| {{- end }} | ||
| backplane: | ||
| {{- if .Values.redis.enabled }} | ||
| redisUri: "redis://{{ printf "%s-redis-master.%s" (include "redis.fullname" .) (.Release.Namespace) }}:{{ "6379" }}" |
There was a problem hiding this comment.
Others have indicated that there may need to be a scheme control here (for rediss://), and the port and presumably operator convention are hard coded.
There was a problem hiding this comment.
ok. I will update the PR later
There was a problem hiding this comment.
@werkt The PR has been updated. Please help to review it, thanks~
werkt
approved these changes
Sep 7, 2023
lshmouse
force-pushed
the
dev/shaohui/helm-charts
branch
from
5483709
to
69ab0bb
Compare
lshmouse
force-pushed
the
dev/shaohui/helm-charts
branch
from
69ab0bb
to
5dd692e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very convenient to deploy an app on k8s using helm chart.
So we add a production-ready helm chart for bazel buildfarm and tested in our k8s cluster.
Suggestions are welcomed, thx~