Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deadlock when handling Write request #1442

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Fix deadlock when handling Write request #1442

merged 3 commits into from
Sep 20, 2023

Conversation

shirchen
Copy link
Contributor

Prevent getOutput from holding a lock on the write while waiting for cancel to get called.

Fixes #1441

werkt
werkt approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@werkt werkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes that look very familiar to me ;)

@werkt werkt merged commit 882e86f into bazelbuild:main Sep 20, 2023
2 checks passed
80degreeswest added a commit that referenced this pull request Oct 7, 2023
@80degreeswest
Revert "Fix deadlock when handling Write request (#1442)"
dfbb686 
This reverts commit 882e86f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@werkt werkt werkt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deadlock in future-waiting Write
2 participants
@shirchen @werkt