feat: support --redis_uri command line option #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documenting this could take the form of another column under https://github.com/bazelbuild/bazel-buildfarm/blob/main/_site/docs/configuration/configuration.md that lists cmdline arg aliases for a config. |
werkt
force-pushed
the
support-redis_uri_cli_options
branch
from
40e88ed
to
0a50941
Compare
|
@jasonschroeder-sfdc did you want to circle back on the docs here, or are you punting for later changes? |
|
@werkt sorry - the ol' day job is killing me with deadlines. I'll squeeze these out today. |
|
Also, is URI or URL the correct term for this? 🤔 |
It is whatever the mechanism we use to interpret it says it is: in this case we're using java.net.URI. As long as nobody changes that, or looks too closely at whether it's the correct usage, itsa URI. |
jasonschroeder-sfdc
force-pushed
the
support-redis_uri_cli_options
branch
from
0a50941
to
377a6c8
Compare
Support a `--redis_uri` command line option for start-up.
also fixed some spelling typos.
werkt
force-pushed
the
support-redis_uri_cli_options
branch
from
377a6c8
to
5f3550e
Compare
werkt
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support a
--redis_uricommand line option for start-up.TODO: I wasn't sure where to document it under
_site? Please let me know if it needs to be in the doc site. Thanks!Partially addresses #1445