-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: start adopting bzlmod #1564
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curiously, EDIT: fixed in 47b4eea |
Will the relevant issue likely be fixed when this is landed? |
Yes, we can link this PR to #1479 |
jasonschroeder-sfdc
force-pushed
the
bzlmod
branch
from
December 19, 2023 01:04
cc4406d
to
b5ab0ad
Compare
Only four bazel dependencies were found in the existing bzlmod registry (https://registry.bazel.build/)
jasonschroeder-sfdc
force-pushed
the
bzlmod
branch
2 times, most recently
from
January 9, 2024 00:03
5a1b0c3
to
47b4eea
Compare
I don't know why. But it works.
jasonschroeder-sfdc
force-pushed
the
bzlmod
branch
from
January 9, 2024 03:07
47b4eea
to
d18e289
Compare
There are conflicts with go tooling between buildtools and protobuf.
werkt
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for doing this legwork!
80degreeswest
added a commit
that referenced
this pull request
Mar 2, 2024
This reverts commit b62a4ce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only four bazel dependencies were found in the existing bzlmod registry (https://registry.bazel.build/)
Fixes: #1479