Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: start adopting bzlmod #1564

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Conversation

jasonschroeder-sfdc
Copy link
Collaborator

@jasonschroeder-sfdc jasonschroeder-sfdc commented Dec 8, 2023

Only four bazel dependencies were found in the existing bzlmod registry (https://registry.bazel.build/)

Fixes: #1479

@jasonschroeder-sfdc
Copy link
Collaborator Author

jasonschroeder-sfdc commented Dec 8, 2023

Curiously, //src/test/java/build/buildfarm/examples:tests is failing 🤔

EDIT: fixed in 47b4eea

@werkt
Copy link
Collaborator

werkt commented Dec 11, 2023

Will the relevant issue likely be fixed when this is landed?

@jasonschroeder-sfdc
Copy link
Collaborator Author

Yes, we can link this PR to #1479

@jasonschroeder-sfdc jasonschroeder-sfdc marked this pull request as ready for review January 9, 2024 00:16
I don't know why. But it works.
Copy link
Collaborator

@werkt werkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for doing this legwork!

@werkt werkt merged commit b62a4ce into bazelbuild:main Jan 9, 2024
2 checks passed
80degreeswest added a commit that referenced this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Bzlmod for managing external dependencies
2 participants