Add helm lint CI job. Split tag/release for the Helm chart from the entire repo with tags: helm/X.Y.Z-b1
#1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrothstein
force-pushed
the
feature/separate-helm-chart-version-and-ci
branch
from
ff47905
to
01d53ba
Compare
werkt
reviewed
Jan 7, 2024
Comment on lines
+134
to
+147
| #nodeSelector: {} | ||
| #tolerations: [] | ||
| #affinity: {} | ||
|
|
||
| #extraVolumes: | ||
| # - name: additionalSecret | ||
| # secret: | ||
| # secretName: my-secret | ||
| # defaultMode: 0600 | ||
|
|
||
| #extraVolumeMounts: | ||
| # - name: customConfig | ||
| # mountPath: /mnt/config | ||
| # readOnly: true |
There was a problem hiding this comment.
This looks similar to your other PR #1604, is this extra/intended, and will the template resolution treat it kindly to have these fields missing?
There was a problem hiding this comment.
yessir, I was having problem melding values between the many layers of yaml generation/engineering we use to ultimately deploy this. I found having no default favorable to having an empty default. Some tools are more confused than others by the difference between the empty set and the set that contains the empty set. I changed the template side to use helm's "with" form to accomodate. the helm generated yaml is, by default, now more brief as well.
andrewrothstein
force-pushed
the
feature/separate-helm-chart-version-and-ci
branch
from
15c9aab
to
bd81edf
Compare
werkt
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.