Publish storage worker and execute worker pool size in prometheus #1606
Conversation
|
Had dependency on #1605, buildfails due to missing newly added field. |
| .register(); | ||
| private static final Gauge executeWorkerPoolSize = | ||
| Gauge.build() | ||
| .name("execute_worker_pool_size") |
There was a problem hiding this comment.
Would be useful to add a labelNames("queue_name") here as you can have multiple pools of execute workers. Also can you please update the config docs with new metrics.
There was a problem hiding this comment.
This will require changes at multiple places.
- Change type of active_workers property in BackplaneStatus. Which will trigger changes in multiple places.
- Include worker queues in ShardWorker
Are we ok with these changes?
There was a problem hiding this comment.
This is fine as is for now. There is a different way to get the workers by type (if running in k8s) with something like this:
count(completed_operations_total) by (job)
where job is a label assigned to a kubernetes deployment.
| .register(); | ||
| private static final Gauge executeWorkerPoolSize = | ||
| Gauge.build() | ||
| .name("execute_worker_pool_size") |
There was a problem hiding this comment.
This is fine as is for now. There is a different way to get the workers by type (if running in k8s) with something like this:
count(completed_operations_total) by (job)
where job is a label assigned to a kubernetes deployment.
werkt
force-pushed
the
prometheus_metrics
branch
from
fce37aa
to
9a14811
Compare
Publish storage worker and execute worker pool size in prometheus