Dequeue flags expire after timeout effect #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag key which contains a timeout for an operation that has been observed in a Queue's Dequeue (atomic safeguard list, either queue or dequeue) must not expire before the time it will be expired, and reasonably not before the time it takes a failsafe period to identify the timeout has elapsed. This was broken in bazelbuild#713, where the original expiry was 2x the configured timeout, and reduced to just the timeout in seconds. We now set the expiry to 1 hour or 10x the timeout, to make unlikely an expiry clearing the flag in a working system. Commented loudly to avoid removing the same padding again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag key which contains a timeout for an operation that has been observed in a Queue's Dequeue (atomic safeguard list, either queue or dequeue) must not expire before the time it will be expired, and reasonably not before the time it takes a failsafe period to identify the timeout has elapsed. This was broken in #713, where the original expiry was 2x the configured timeout, and reduced to just the timeout in seconds. We now set the expiry to 1 hour or 10x the timeout, to make unlikely an expiry clearing the flag in a working system. Commented loudly to avoid removing the same padding again.