Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helm] Support autoscaling/{v2beta2,v2} for HPA. #1666

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[helm] Support autoscaling/{v2beta2,v2} for HPA. #1666

merged 1 commit into from
Mar 11, 2024

Conversation

monaka
Copy link
Contributor

@monaka monaka commented Mar 9, 2024 •
edited

Currently the Helm chart supports HPA v1 only.
That API version is too old.

I tested this with AKS 1.28.5.

$ kubectl version --short
Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.
Client Version: v1.26.13
Kustomize Version: v4.5.7
Server Version: v1.28.5

@monaka monaka requested a review from werkt as a code owner March 9, 2024 10:02
werkt
werkt approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@werkt werkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a noop, thanks!

@werkt werkt merged commit 2490ada into bazelbuild:main Mar 11, 2024
2 checks passed
@monaka monaka deleted the pr-hpa-v2 branch March 13, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@werkt werkt werkt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@monaka @werkt