Switch to jedis-5 #1677
Merged
Switch to jedis-5 #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonschroeder-sfdc
approved these changes
Mar 21, 2024
src/main/java/build/buildfarm/common/redis/RedisNodeHashes.java
Outdated
Show resolved
Hide resolved
src/main/java/build/buildfarm/common/redis/RedisPriorityQueue.java
Outdated
Show resolved
Hide resolved
src/main/java/build/buildfarm/common/redis/RedisSlotToHash.java
Outdated
Show resolved
Hide resolved
werkt
force-pushed
the
jedis-5
branch
4 times, most recently
from
724c06e
to
ac35c59
Compare
The slot key index is invariant for all usage, calculate it once and avoid a costly lookup for successive calls to RedisSlotToHash.correlate. Evidenced in slow unit tests, but may improve production runtime as well. Provide an initial capacity to the slots ArrayList to boot.
Speeds up tests dramatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1661
Calculate slot lookup table once per app instance
The slot key index is invariant for all usage, calculate it once and
avoid a costly lookup for successive calls to RedisSlotToHash.correlate.
Evidenced in slow unit tests, but may improve production runtime as
well. Provide an initial capacity to the slots ArrayList to boot.
Switch jedis dequeue over to milli granularity
Speeds up tests dramatically.