Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redis hashtags from prometheus metrics #1693

Merged

Conversation

jasonschroeder-sfdc
Copy link
Collaborator

@jasonschroeder-sfdc jasonschroeder-sfdc commented Apr 1, 2024

Strip the redis hashtags from the queue_size metric

Alternate fix is in #1687

Fixes: #1686

Strip the redis hashtags from the `queue_size` metric

Fixes: bazelbuild#1687
Copy link
Collaborator

@werkt werkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does bind us up with the redis namespace for the first time in ServerInstance, but I prefer this static usage to anything else.

@werkt werkt merged commit 2a8afb3 into bazelbuild:main Apr 1, 2024
4 checks passed
@jasonschroeder-sfdc jasonschroeder-sfdc deleted the strip-redis-hash-for-metrics branch April 1, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheus metric is malformed
2 participants