Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): guard against empty RedisURI #1735

Merged
merged 1 commit into from
May 15, 2024

Conversation

jasonschroeder-sfdc
Copy link
Collaborator

If a customer does not use redisUri: in the configuration, and instead uses redisNodes:, this can throw a NPE.

If a customer does not use `redisUri:` in the configuration, and instead
uses `redisNodes:`, this can throw a NPE.
Copy link
Collaborator

@werkt werkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this happens actually any time there's a syntax error in the config as well, so good to have it cleaned up.

@werkt werkt merged commit a40473e into bazelbuild:main May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants