Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support darwin-arm64 for code formatting #1783

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jasonschroeder-sfdc
Copy link
Collaborator

@jasonschroeder-sfdc jasonschroeder-sfdc commented Jun 21, 2024

This PR adds support for arm64 mac for code formatting.

darwin-x86_64, as well as linux-arm64, requested at google/google-java-format#1115

@@ -15,13 +38,6 @@ fi
FORMAT_BUILD=true
BUILDIFIER=//:buildifier

# Print an error such that it will surface in the context of buildkite
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to line 9

Copy link
Collaborator

@werkt werkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement. Could downcase the os component and compose the url string with it in a single line rather than the ifs and let the http failure solve it (with a set -e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants