M Execution logging #191
Merged
M Execution logging #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With an addition to the README.md to use an example logging configuration to provide some feedback on executions.
Closed
| Process process; | ||
| try { | ||
| process = processBuilder.start(); | ||
| process.getOutputStream().close(); | ||
| } catch(IOException ex) { | ||
| ex.printStackTrace(); | ||
| // again, should we do something else here?? | ||
| resultBuilder.setExitCode(exitValue); | ||
| resultBuilder.setExitCode(exitCode); |
There was a problem hiding this comment.
Sorry, I'm having a code-read fail -- can the exitCode here ever be not -1?
There was a problem hiding this comment.
It cannot, the exitCode assignments after the default initialization all occur after this. lmk if you think that merits different behavior here
There was a problem hiding this comment.
Oh, then I would very much prefer you just say -1 here, to not make the reader think about what the value might be.
There was a problem hiding this comment.
Pedantically, I used the exitCode here to match the releaseExecutor information propagated to the ExecuteActionStage so that there would not be any discontinuity between what is logged and what is recorded in the resultBuilder, but I see the point.
ola-rozenfeld
approved these changes
Nov 1, 2018
Use a constant to describe an incomplete exit code as a result of an IOException on process creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an addition to the README.md to use an example logging
configuration to provide some feedback on executions.