[discussion] issue 975 example fix #976
Conversation
|
Definitely need some discussion on this. Can you frame the situation that you discovered to determine that the entry is actually missing on the filesystem? The longer term presentation here is that we need to a) invalidate the entry if it no longer exists, b) invalidate the downstream directories that contain it, and c) switch to a future to ensure that we can block all concurrent requests for this truth on it, assuming we move ahead with this. |
|
thanks! yeah, this worked and fixed #975. since our deployment system is locked down till early january, i need to wait to deploy it there to test this out. |
| @@ -393,7 +397,7 @@ private boolean contains( | |||
| result.mergeFrom(digest).setSizeBytes(entry.size); | |||
| } | |||
| onContains.accept(key); | |||
| return true; | |||
| return blobExistsOnLocalStorage(key); | |||
There was a problem hiding this comment.
To prevent the extra overhead, can we only perform the check if ensure outputs present is set?
There was a problem hiding this comment.
that's a good idea. I'll adjust for that.
No description provided.