Ignore purego build constraint
#1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
reviewed
Mar 28, 2024
fmeum
approved these changes
Mar 28, 2024
`purego` is a proposed[1] de-facto build constraint to denote building _only_ Go code. We must ignore this constraint to make sure that files that toggle on `purego` are added to the Bazel target `srcs` and let the compiler decide if they should be compiled or not. [1]: golang/go#23172
mattyclarkson
force-pushed
the
purest-of-pure
branch
from
9364538
to
c1d5a50
Compare
fmeum
approved these changes
Mar 28, 2024
renovate bot
added a commit
to kreempuff/rules_unreal_engine
that referenced
this pull request
Apr 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.35.0` -> `v0.36.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary> ### [`v0.36.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.36.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.35.0...v0.36.0) #### What's Changed - Test with incompatible flags by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1696 - adding more default gazelle overrides by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/bazel-gazelle#1701 - rule: add accessor for attribute comments by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1700 - rule: set update flag on Rule.AddArg by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1702 - rule: rename GetAttrComments -> AttrComments by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1703 - Remove some usage of deprecated ioutil by [@​dzbarsky](https://togithub.com/dzbarsky) in [bazelbuild/bazel-gazelle#1704 - Allow passing Gazelle binary as a file by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/bazel-gazelle#1706 - rule: allow usage of Label struct with Rule APIs by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1705 - Remove ioutil usage by [@​dzbarsky](https://togithub.com/dzbarsky) in [bazelbuild/bazel-gazelle#1707 - doc: fix link to Swift gazelle plugin by [@​cgrindel](https://togithub.com/cgrindel) in [bazelbuild/bazel-gazelle#1708 - Fix two shellcheck warnings in gazelle.bash.in by [@​mortenmj](https://togithub.com/mortenmj) in [bazelbuild/bazel-gazelle#1710 - implement expression conversions via BzlExprValue interface by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1714 - update documentation for 0.35 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1712 - Update circl to v1.3.7 in tests by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1718 - rule: make value sorting configurable (alternative implementation) by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1719 - Add check in `update-repos` to omit reading `WORKSPACE` on bzlmod only repos. by [@​Megakuul](https://togithub.com/Megakuul) in [bazelbuild/bazel-gazelle#1727 - Add default gazelle override for github.com/cockroachdb/errors. by [@​fardream](https://togithub.com/fardream) in [bazelbuild/bazel-gazelle#1728 - README: fix resolve_regexp doc by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1729 - feat(bzlmod): allow `default_gazelle_attributes` for `go_deps` extension by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1716 - add new std_packages from go 1.22 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1740 - fix: wrap generation test labels with Label() by [@​pedrobarco](https://togithub.com/pedrobarco) in [bazelbuild/bazel-gazelle#1743 - proto: Add Bzlmod support for well-known types by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1741 - Test BCR with Bazel 6.5.0 and 7.0.2 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1744 - Set go_naming_convention for cel-go by [@​riking](https://togithub.com/riking) in [bazelbuild/bazel-gazelle#1746 - nit: fix error message in go_repository by [@​hauserx](https://togithub.com/hauserx) in [bazelbuild/bazel-gazelle#1750 - Add `go_deps.config(env = ...)` as a replacement for `gazelle_dependencies(go_env = ...)` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1748 - Warn if integrity not specified for archive_override by [@​scaiper](https://togithub.com/scaiper) in [bazelbuild/bazel-gazelle#1753 - Use host module cache whithout build cache and verify it by [@​scaiper](https://togithub.com/scaiper) in [bazelbuild/bazel-gazelle#1755 - Update default_gazelle_overrides.bzl by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1758 - Mark `go_deps` extension as reproducible by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1761 - Ignore `purego` build constraint by [@​mattyclarkson](https://togithub.com/mattyclarkson) in [bazelbuild/bazel-gazelle#1767 - Expose path to root `go.mod` to rules_go by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1762 - Fix and expand `reproducible` usage in extensions by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1763 - Add is_bazel_module to deps.bzl. by [@​spags-lacework](https://togithub.com/spags-lacework) in [bazelbuild/bazel-gazelle#1771 - prepare release 0.36 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1752 #### New Contributors - [@​t-8ch](https://togithub.com/t-8ch) made their first contribution in [bazelbuild/bazel-gazelle#1700 - [@​dzbarsky](https://togithub.com/dzbarsky) made their first contribution in [bazelbuild/bazel-gazelle#1704 - [@​Megakuul](https://togithub.com/Megakuul) made their first contribution in [bazelbuild/bazel-gazelle#1727 - [@​fardream](https://togithub.com/fardream) made their first contribution in [bazelbuild/bazel-gazelle#1728 - [@​pedrobarco](https://togithub.com/pedrobarco) made their first contribution in [bazelbuild/bazel-gazelle#1743 - [@​riking](https://togithub.com/riking) made their first contribution in [bazelbuild/bazel-gazelle#1746 - [@​hauserx](https://togithub.com/hauserx) made their first contribution in [bazelbuild/bazel-gazelle#1750 - [@​scaiper](https://togithub.com/scaiper) made their first contribution in [bazelbuild/bazel-gazelle#1753 - [@​mattyclarkson](https://togithub.com/mattyclarkson) made their first contribution in [bazelbuild/bazel-gazelle#1767 - [@​spags-lacework](https://togithub.com/spags-lacework) made their first contribution in [bazelbuild/bazel-gazelle#1771 **Full Changelog**: bazelbuild/bazel-gazelle@v0.35.0...v0.36.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/bazel-starlib
that referenced
this pull request
Apr 3, 2024
](https://renovatebot.com){kind=link}
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.35.0` -> `v0.36.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary> ### [`v0.36.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.36.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.35.0...v0.36.0) #### What's Changed - Test with incompatible flags by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1696 - adding more default gazelle overrides by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/bazel-gazelle#1701 - rule: add accessor for attribute comments by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1700 - rule: set update flag on Rule.AddArg by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1702 - rule: rename GetAttrComments -> AttrComments by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1703 - Remove some usage of deprecated ioutil by [@​dzbarsky](https://togithub.com/dzbarsky) in [bazelbuild/bazel-gazelle#1704 - Allow passing Gazelle binary as a file by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/bazel-gazelle#1706 - rule: allow usage of Label struct with Rule APIs by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1705 - Remove ioutil usage by [@​dzbarsky](https://togithub.com/dzbarsky) in [bazelbuild/bazel-gazelle#1707 - doc: fix link to Swift gazelle plugin by [@​cgrindel](https://togithub.com/cgrindel) in [bazelbuild/bazel-gazelle#1708 - Fix two shellcheck warnings in gazelle.bash.in by [@​mortenmj](https://togithub.com/mortenmj) in [bazelbuild/bazel-gazelle#1710 - implement expression conversions via BzlExprValue interface by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1714 - update documentation for 0.35 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1712 - Update circl to v1.3.7 in tests by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1718 - rule: make value sorting configurable (alternative implementation) by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1719 - Add check in `update-repos` to omit reading `WORKSPACE` on bzlmod only repos. by [@​Megakuul](https://togithub.com/Megakuul) in [bazelbuild/bazel-gazelle#1727 - Add default gazelle override for github.com/cockroachdb/errors. by [@​fardream](https://togithub.com/fardream) in [bazelbuild/bazel-gazelle#1728 - README: fix resolve_regexp doc by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1729 - feat(bzlmod): allow `default_gazelle_attributes` for `go_deps` extension by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1716 - add new std_packages from go 1.22 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1740 - fix: wrap generation test labels with Label() by [@​pedrobarco](https://togithub.com/pedrobarco) in [bazelbuild/bazel-gazelle#1743 - proto: Add Bzlmod support for well-known types by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1741 - Test BCR with Bazel 6.5.0 and 7.0.2 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1744 - Set go_naming_convention for cel-go by [@​riking](https://togithub.com/riking) in [bazelbuild/bazel-gazelle#1746 - nit: fix error message in go_repository by [@​hauserx](https://togithub.com/hauserx) in [bazelbuild/bazel-gazelle#1750 - Add `go_deps.config(env = ...)` as a replacement for `gazelle_dependencies(go_env = ...)` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1748 - Warn if integrity not specified for archive_override by [@​scaiper](https://togithub.com/scaiper) in [bazelbuild/bazel-gazelle#1753 - Use host module cache whithout build cache and verify it by [@​scaiper](https://togithub.com/scaiper) in [bazelbuild/bazel-gazelle#1755 - Update default_gazelle_overrides.bzl by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1758 - Mark `go_deps` extension as reproducible by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1761 - Ignore `purego` build constraint by [@​mattyclarkson](https://togithub.com/mattyclarkson) in [bazelbuild/bazel-gazelle#1767 - Expose path to root `go.mod` to rules_go by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1762 - Fix and expand `reproducible` usage in extensions by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1763 - Add is_bazel_module to deps.bzl. by [@​spags-lacework](https://togithub.com/spags-lacework) in [bazelbuild/bazel-gazelle#1771 - prepare release 0.36 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1752 #### New Contributors - [@​t-8ch](https://togithub.com/t-8ch) made their first contribution in [bazelbuild/bazel-gazelle#1700 - [@​dzbarsky](https://togithub.com/dzbarsky) made their first contribution in [bazelbuild/bazel-gazelle#1704 - [@​Megakuul](https://togithub.com/Megakuul) made their first contribution in [bazelbuild/bazel-gazelle#1727 - [@​fardream](https://togithub.com/fardream) made their first contribution in [bazelbuild/bazel-gazelle#1728 - [@​pedrobarco](https://togithub.com/pedrobarco) made their first contribution in [bazelbuild/bazel-gazelle#1743 - [@​riking](https://togithub.com/riking) made their first contribution in [bazelbuild/bazel-gazelle#1746 - [@​hauserx](https://togithub.com/hauserx) made their first contribution in [bazelbuild/bazel-gazelle#1750 - [@​scaiper](https://togithub.com/scaiper) made their first contribution in [bazelbuild/bazel-gazelle#1753 - [@​mattyclarkson](https://togithub.com/mattyclarkson) made their first contribution in [bazelbuild/bazel-gazelle#1767 - [@​spags-lacework](https://togithub.com/spags-lacework) made their first contribution in [bazelbuild/bazel-gazelle#1771 **Full Changelog**: bazelbuild/bazel-gazelle@v0.35.0...v0.36.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
mattyclarkson
added a commit
to mattyclarkson/rules_go
that referenced
this pull request
Apr 3, 2024
The community has agreed[1] that "pure" builds of Go code should use the `purego` build tag. This change adds that de-facto tag. The minimum version of Gazelle is bumped to `0.36.0` which includes a patch[2] for ignoring the `purego` tag so that the source flies are passed to the compiler for conditional compilation decisions. [1]: golang/go#23172 [2]: bazelbuild/bazel-gazelle#1767
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Apr 4, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.35.0` -> `v0.36.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary> ### [`v0.36.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.36.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.35.0...v0.36.0) #### What's Changed - Test with incompatible flags by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1696 - adding more default gazelle overrides by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/bazel-gazelle#1701 - rule: add accessor for attribute comments by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1700 - rule: set update flag on Rule.AddArg by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1702 - rule: rename GetAttrComments -> AttrComments by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1703 - Remove some usage of deprecated ioutil by [@​dzbarsky](https://togithub.com/dzbarsky) in [bazelbuild/bazel-gazelle#1704 - Allow passing Gazelle binary as a file by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/bazel-gazelle#1706 - rule: allow usage of Label struct with Rule APIs by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1705 - Remove ioutil usage by [@​dzbarsky](https://togithub.com/dzbarsky) in [bazelbuild/bazel-gazelle#1707 - doc: fix link to Swift gazelle plugin by [@​cgrindel](https://togithub.com/cgrindel) in [bazelbuild/bazel-gazelle#1708 - Fix two shellcheck warnings in gazelle.bash.in by [@​mortenmj](https://togithub.com/mortenmj) in [bazelbuild/bazel-gazelle#1710 - implement expression conversions via BzlExprValue interface by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1714 - update documentation for 0.35 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1712 - Update circl to v1.3.7 in tests by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1718 - rule: make value sorting configurable (alternative implementation) by [@​t-8ch](https://togithub.com/t-8ch) in [bazelbuild/bazel-gazelle#1719 - Add check in `update-repos` to omit reading `WORKSPACE` on bzlmod only repos. by [@​Megakuul](https://togithub.com/Megakuul) in [bazelbuild/bazel-gazelle#1727 - Add default gazelle override for github.com/cockroachdb/errors. by [@​fardream](https://togithub.com/fardream) in [bazelbuild/bazel-gazelle#1728 - README: fix resolve_regexp doc by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1729 - feat(bzlmod): allow `default_gazelle_attributes` for `go_deps` extension by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1716 - add new std_packages from go 1.22 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1740 - fix: wrap generation test labels with Label() by [@​pedrobarco](https://togithub.com/pedrobarco) in [bazelbuild/bazel-gazelle#1743 - proto: Add Bzlmod support for well-known types by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1741 - Test BCR with Bazel 6.5.0 and 7.0.2 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1744 - Set go_naming_convention for cel-go by [@​riking](https://togithub.com/riking) in [bazelbuild/bazel-gazelle#1746 - nit: fix error message in go_repository by [@​hauserx](https://togithub.com/hauserx) in [bazelbuild/bazel-gazelle#1750 - Add `go_deps.config(env = ...)` as a replacement for `gazelle_dependencies(go_env = ...)` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1748 - Warn if integrity not specified for archive_override by [@​scaiper](https://togithub.com/scaiper) in [bazelbuild/bazel-gazelle#1753 - Use host module cache whithout build cache and verify it by [@​scaiper](https://togithub.com/scaiper) in [bazelbuild/bazel-gazelle#1755 - Update default_gazelle_overrides.bzl by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1758 - Mark `go_deps` extension as reproducible by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1761 - Ignore `purego` build constraint by [@​mattyclarkson](https://togithub.com/mattyclarkson) in [bazelbuild/bazel-gazelle#1767 - Expose path to root `go.mod` to rules_go by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1762 - Fix and expand `reproducible` usage in extensions by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1763 - Add is_bazel_module to deps.bzl. by [@​spags-lacework](https://togithub.com/spags-lacework) in [bazelbuild/bazel-gazelle#1771 - prepare release 0.36 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1752 #### New Contributors - [@​t-8ch](https://togithub.com/t-8ch) made their first contribution in [bazelbuild/bazel-gazelle#1700 - [@​dzbarsky](https://togithub.com/dzbarsky) made their first contribution in [bazelbuild/bazel-gazelle#1704 - [@​Megakuul](https://togithub.com/Megakuul) made their first contribution in [bazelbuild/bazel-gazelle#1727 - [@​fardream](https://togithub.com/fardream) made their first contribution in [bazelbuild/bazel-gazelle#1728 - [@​pedrobarco](https://togithub.com/pedrobarco) made their first contribution in [bazelbuild/bazel-gazelle#1743 - [@​riking](https://togithub.com/riking) made their first contribution in [bazelbuild/bazel-gazelle#1746 - [@​hauserx](https://togithub.com/hauserx) made their first contribution in [bazelbuild/bazel-gazelle#1750 - [@​scaiper](https://togithub.com/scaiper) made their first contribution in [bazelbuild/bazel-gazelle#1753 - [@​mattyclarkson](https://togithub.com/mattyclarkson) made their first contribution in [bazelbuild/bazel-gazelle#1767 - [@​spags-lacework](https://togithub.com/spags-lacework) made their first contribution in [bazelbuild/bazel-gazelle#1771 **Full Changelog**: bazelbuild/bazel-gazelle@v0.35.0...v0.36.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
mattyclarkson
added a commit
to mattyclarkson/rules_go
that referenced
this pull request
Apr 5, 2024
The community has agreed[1] that "pure" builds of Go code should use the `purego` build tag. This change adds that de-facto tag. The minimum version of Gazelle is bumped to `0.36.0` which includes a patch[2] for ignoring the `purego` tag so that the source flies are passed to the compiler for conditional compilation decisions. [1]: golang/go#23172 [2]: bazelbuild/bazel-gazelle#1767
mattyclarkson
added a commit
to mattyclarkson/rules_go
that referenced
this pull request
Apr 5, 2024
The community has agreed[1] that "pure" builds of Go code should use the `purego` build tag. This change adds that de-facto tag. The minimum version of Gazelle is bumped to `0.36.0` which includes a patch[2] for ignoring the `purego` tag so that the source flies are passed to the compiler for conditional compilation decisions. [1]: golang/go#23172 [2]: bazelbuild/bazel-gazelle#1767
mattyclarkson
added a commit
to mattyclarkson/rules_go
that referenced
this pull request
Apr 6, 2024
The community has agreed[1] that "pure" builds of Go code should use the `purego` build tag. This change adds that de-facto tag. The minimum version of Gazelle is bumped to `0.36.0` which includes a patch[2] for ignoring the `purego` tag so that the source flies are passed to the compiler for conditional compilation decisions. [1]: golang/go#23172 [2]: bazelbuild/bazel-gazelle#1767
mattyclarkson
added a commit
to mattyclarkson/rules_go
that referenced
this pull request
Apr 6, 2024
The community has agreed[1] that "pure" builds of Go code should use the `purego` build tag. This change adds that de-facto tag. The minimum version of Gazelle is bumped to `0.36.0` which includes a patch[2] for ignoring the `purego` tag so that the source flies are passed to the compiler for conditional compilation decisions. [1]: golang/go#23172 [2]: bazelbuild/bazel-gazelle#1767
mattyclarkson
added a commit
to mattyclarkson/rules_go
that referenced
this pull request
Apr 6, 2024
The community has agreed[1] that "pure" builds of Go code should use the `purego` build tag. This change adds that de-facto tag. The minimum version of Gazelle is bumped to `0.36.0` which includes a patch[2] for ignoring the `purego` tag so that the source flies are passed to the compiler for conditional compilation decisions. [1]: golang/go#23172 [2]: bazelbuild/bazel-gazelle#1767
mattyclarkson
added a commit
to mattyclarkson/rules_go
that referenced
this pull request
Apr 10, 2024
The community has agreed[1] that "pure" builds of Go code should use the `purego` build tag. This change adds that de-facto tag. The minimum version of Gazelle is bumped to `0.36.0` which includes a patch[2] for ignoring the `purego` tag so that the source flies are passed to the compiler for conditional compilation decisions. [1]: golang/go#23172 [2]: bazelbuild/bazel-gazelle#1767
mattyclarkson
added a commit
to mattyclarkson/rules_go
that referenced
this pull request
Apr 25, 2024
The community has agreed[1] that "pure" builds of Go code should use the `purego` build tag. This change adds that de-facto tag. The minimum version of Gazelle is bumped to `0.36.0` which includes a patch[2] for ignoring the `purego` tag so that the source flies are passed to the compiler for conditional compilation decisions. [1]: golang/go#23172 [2]: bazelbuild/bazel-gazelle#1767
mattyclarkson
added a commit
to mattyclarkson/rules_go
that referenced
this pull request
May 2, 2024
The community has agreed[1] that "pure" builds of Go code should use the `purego` build tag. This change adds that de-facto tag. The minimum version of Gazelle is bumped to `0.36.0` which includes a patch[2] for ignoring the `purego` tag so that the source flies are passed to the compiler for conditional compilation decisions. [1]: golang/go#23172 [2]: bazelbuild/bazel-gazelle#1767
mattyclarkson
added a commit
to mattyclarkson/rules_go
that referenced
this pull request
May 4, 2024
The community has agreed[1] that "pure" builds of Go code should use the `purego` build tag. This change adds that de-facto tag. The minimum version of Gazelle is bumped to `0.36.0` which includes a patch[2] for ignoring the `purego` tag so that the source flies are passed to the compiler for conditional compilation decisions. [1]: golang/go#23172 [2]: bazelbuild/bazel-gazelle#1767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puregois a proposed1 de-facto build constraint to denote building only Go code.We must ignore this constraint to make sure that files that toggle on
puregoare added to the Bazel targetsrcsand let the compiler decide if they should be compiled or not.This is required to land bazelbuild/rules_go#3901 which will enable the de-facto
puregobuild constraint to be picked up in the Bazel Go ecosystem automatically whenpure = "on"is defined in ago_binary, etc.