Ensure the Gazelle binary is built for the right platform #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we pick Gazelle for the "exec" platform. This isn't correct, because we are not running Gazelle as part of a build action. Instead, we are emitting a shell script that *invokes* Gazelle. That's why we need to make sure it's built for the target platform. This addresses an issue where Bazel ends up invoking a copy of Gazelle for Linux on my Mac, if I invoke bazel with --extra_execution_platforms=//my_linux_platform,//my_mac_platform.
fmeum
approved these changes
May 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
cmd/gazelle
What does this PR do? Why is it needed?
Right now we pick Gazelle for the "exec" platform. This isn't correct, because we are not running Gazelle as part of a build action. Instead, we are emitting a shell script that invokes Gazelle. That's why we need to make sure it's built for the target platform.
This addresses an issue where Bazel ends up invoking a copy of Gazelle for Linux on my Mac, if I invoke bazel with
--extra_execution_platforms=//my_linux_platform,//my_mac_platform.
Which issues(s) does this PR fix?
n/a
Other notes for review