Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the Gazelle binary is built for the right platform #1803

Merged
merged 1 commit into from
May 16, 2024

Commits on May 16, 2024

  1. Ensure the Gazelle binary is built for the right platform

    Right now we pick Gazelle for the "exec" platform. This isn't correct,
    because we are not running Gazelle as part of a build action. Instead,
    we are emitting a shell script that *invokes* Gazelle. That's why we
    need to make sure it's built for the target platform.
    
    This addresses an issue where Bazel ends up invoking a copy of Gazelle
    for Linux on my Mac, if I invoke bazel with
    --extra_execution_platforms=//my_linux_platform,//my_mac_platform.
    EdSchouten committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7123212 View commit details
    Browse the repository at this point in the history