-
Notifications
You must be signed in to change notification settings - Fork 178
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow sandboxing for copy_* and fix copy_directory tests (#392)
After some thought, I have to say that forcing a local strategy for copy_file/copy_directory is inappropriate. The point of a sandbox is to catch hermeticity bugs; disabling the sandbox may be useful for performance, but it's up to the user to do it if they trust us - and they can do it via flag. The default should be paranoia and safety. And on the subject of strategies - using a genrule to create an empty directory fails in environments where genrules run remote by default (and thus, copy_directory tests fail). We could, of course, set local=1, but that disables the sandbox and causes scary warnings. Instead, add a proper empty_directory rule to test with.
- Loading branch information
Showing
3 changed files
with
37 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
# Copyright 2022 The Bazel Authors. All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Creates an empty directory.""" | ||
|
||
def _empty_directory_impl(ctx): | ||
out = ctx.actions.declare_directory(ctx.attr.name) | ||
ctx.actions.run_shell( | ||
outputs = [out], | ||
command = "mkdir -p $@", | ||
arguments = [out.path], | ||
mnemonic = "EmptyDirectory", | ||
progress_message = "Creating empty directory %s" % out.path, | ||
use_default_shell_env = True, | ||
execution_requirements = {"no-remote": "1"}, # see rules/private/copy_directory_private.bzl | ||
) | ||
return [DefaultInfo(files = depset(direct = [out]))] | ||
|
||
empty_directory = rule( | ||
implementation = _empty_directory_impl, | ||
provides = [DefaultInfo], | ||
doc = "Creates an empty directory with the same name as the target", | ||
) |