Address lint errors #254
Merged
Address lint errors #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achew22
requested review from
aiuto,
c-parsons,
jin and
laurentlb
as code owners
achew22
force-pushed
the
lint
branch
4 times, most recently
from
260b7f0
to
7aff8c1
Compare
|
@laurentlb it looks like it is not possible to fix all the linter errors in the repo. See bazelbuild/buildtools#865 for a more complete explanation of this. Can you advise on how to proceed? |
vladmos
reviewed
Jun 19, 2020
rules/common_settings.bzl
Outdated
| @@ -12,6 +12,8 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| # buildifier: disable=skylark-docstring | |||
| # buildifier: disable=skylark-comment | |||
There was a problem hiding this comment.
These comments are not required anymore, the latest version of buildifer shouldn't warn about the usage of this url anymore.
|
I see just one warning in the CI, it should disappear if you rerun the tests (the CI automatically uses the latest version of buildifier released). Also the disabling comments aren't required anymore. |
|
Looks like that fixed it. Thanks for addressing the linter issues @vladmos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.