Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibazel does not pass arguments to Bazel #13

Closed
endobson opened this issue Jun 1, 2017 · 5 comments
Closed

ibazel does not pass arguments to Bazel #13

endobson opened this issue Jun 1, 2017 · 5 comments

Comments

@endobson
Copy link

endobson commented Jun 1, 2017

I want to run my tests in parallel and ibazel adds --test_output=streamed to the args when running bazel test, which is unexpected and undocumented. I would expect it to just run exactly the same had the command line been bazel test.

@achew22
Copy link
Member

achew22 commented Jul 31, 2017

@endobson Sorry for the really slow response. The presumption here is that you would like all blaze test args to be sent along to later commands but that we would need to filter the args list to only take things that are shaped like a target for query. That seems possible. Especially given the refactor I did recently. Is this a thing you would be interested in taking on?

@kamalmarhubi
Copy link

Relatedly: ibazel cannot pass any arguments to bazel. I spent some time trying to understand why ibazel run //path/to:some_binary -- --an-arg wasn't working.

I'm including this here because it's related. The issue could maybe be renamed to support passing arguments to bazel.

@ittaiz
Copy link
Member

ittaiz commented Aug 2, 2017 via email

@achew22 achew22 changed the title ibazel does not document that it runs tests in streamed mode ibazel does not pass arguments to Bazel Sep 6, 2017
achew22 added a commit that referenced this issue Sep 7, 2017
Now when you pass in arguments to ibazel it should pass them through to
bazel or to your running job if you pass it after a `--`.  Fixes #13.

Also this no longer sets --test_output=streamed by default.
@yzhao1012
Copy link

This does not seem work as expected.

ibazel test //path/to:target -- --test_output=all

This would not make the test to produce all output as the following does:

bazel test //path/to:target --test_output all

@achew22
Copy link
Member

achew22 commented Apr 30, 2019

When you put the extra -- in there, all flags past that are directly passed to the binary. The more equivilent command would be bazel test //path/to:target -- --test_output=all. Can you try running

ibazel test --test_output=all //path/to:target

and tell me if that works?

Also, in the future it would be nice if you could open a new issue instead of commenting on a closed one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants