-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the live_reload test run a real browser #108
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrMarcII
reviewed
Jul 23, 2018
build --workspace_status_command=tools/workplace_status.sh | ||
|
||
# Flags used during releases | ||
# Pass Sauce Labs environment variables through. | ||
build --action_env=SAUCE_USERNAME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These only needed to passed on test
DrMarcII
reviewed
Jul 23, 2018
e2e/live_reload/BUILD
Outdated
}, | ||
browsers = [ | ||
"@io_bazel_rules_webtesting//browsers:chromium-local", | ||
"@io_bazel_rules_webtesting//browsers/sauce:chrome-win10-connect", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use -connect
This is a true E2E test with nothing faked. It runs a real python webserver on a real FS where files are changed and the browser reloads with new page contents.
Stale pull request message |
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a true E2E test with nothing faked. It runs a real python
webserver on a real FS where files are changed and the browser reloads
with new page contents.