Flip --incompatible_no_support_tools_in_action_inputs

Fixes #5826 RELNOTES: Flip --incompatible_no_support_tools_in_action_inputs PiperOrigin-RevId: 250930436
bazelbuild · May 31, 2019 · 0e6dcee · 0e6dcee
1 parent eb53de2
commit 0e6dcee
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java
@@ -450,7 +450,7 @@ public class StarlarkSemanticsOptions extends OptionsBase implements Serializabl
 
   @Option(
       name = "incompatible_no_support_tools_in_action_inputs",
-      defaultValue = "false",
+      defaultValue = "true",
       documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
       effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS},
       metadataTags = {

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java b/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java
@@ -248,7 +248,7 @@ public static Builder builderWithDefaults() {
           .incompatibleNoAttrLicense(true)
           .incompatibleNoKwargsInBuildFiles(true)
           .incompatibleNoOutputAttrDefault(true)
-          .incompatibleNoSupportToolsInActionInputs(false)
+          .incompatibleNoSupportToolsInActionInputs(true)
           .incompatibleNoTargetOutputGroup(false)
           .incompatibleNoTransitiveLoads(true)
           .incompatibleObjcFrameworkCleanup(true)

diff --git a/src/test/py/bazel/native_test.bzl b/src/test/py/bazel/native_test.bzl
@@ -39,7 +39,7 @@ bat_test = rule(
 def _exe_test_impl(ctx):
     out = ctx.actions.declare_file(ctx.label.name + "." + ctx.file.src.extension)
     ctx.actions.run(
-        inputs = [ctx.file.src],
+        tools = [ctx.file.src],
         outputs = [out],
         executable = "cmd.exe",
         arguments = ["/C", "copy /Y %IN% %OUT%"],

diff --git a/src/test/shell/bazel/local_repository_test.sh b/src/test/shell/bazel/local_repository_test.sh
@@ -696,7 +696,7 @@ EOF
 def impl(ctx):
     ctx.actions.run_shell(
         command = "cat %s > %s" % (ctx.file._dep.path, ctx.outputs.sh.path),
-        inputs = [ctx.file._dep],
+        tools = [ctx.file._dep],
         outputs = [ctx.outputs.sh]
     )
 

diff --git a/src/test/shell/integration/py_args_escaping_test.sh b/src/test/shell/integration/py_args_escaping_test.sh
@@ -345,7 +345,7 @@ def _impl(ctx):
     tool_inputs, tool_input_mfs = ctx.resolve_tools(tools = [ctx.attr.tool])
     ctx.actions.run(
         outputs = [ctx.outputs.out],
-        inputs = tool_inputs,
+        tools = tool_inputs,
         executable = ctx.executable.tool,
         arguments = [ctx.outputs.out.path, "a", "", "\"b \\\"c", "z"],
         use_default_shell_env = True,