Skip to content

Commit

Permalink
Flip incompatible_fail_on_unknown_attributes
Browse files Browse the repository at this point in the history
RELNOTES[INC]: Fails on unknown attributes (even when set to None). See #19403

Note: there's still a downstream failure in Bazel Examples, but we know how to fix them.
PiperOrigin-RevId: 565092865
Change-Id: Ic3bf86f1bf0e8c844100d82f5d72170d611b561c
  • Loading branch information
comius authored and Copybara-Service committed Sep 13, 2023
1 parent 48b2604 commit 5f4a0b2
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -702,10 +702,10 @@ public final class BuildLanguageOptions extends OptionsBase {
+ "from the top level target instead")
public boolean incompatibleDisableObjcLibraryTransition;

// cleanup, flip, remove after Bazel LTS in Nov 2023
// remove after Bazel LTS in Nov 2023
@Option(
name = "incompatible_fail_on_unknown_attributes",
defaultValue = "false",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
Expand Down Expand Up @@ -905,7 +905,7 @@ public StarlarkSemantics toStarlarkSemantics() {
public static final String INCOMPATIBLE_DISABLE_OBJC_LIBRARY_TRANSITION =
"-incompatible_disable_objc_library_transition";
public static final String INCOMPATIBLE_FAIL_ON_UNKNOWN_ATTRIBUTES =
"-incompatible_fail_on_unknown_attributes";
"+incompatible_fail_on_unknown_attributes";

// non-booleans
public static final StarlarkSemantics.Key<String> EXPERIMENTAL_BUILTINS_BZL_PATH =
Expand Down

0 comments on commit 5f4a0b2

Please sign in to comment.