Skip to content

Commit

Permalink
Promote some experimental flags to non-experimental that we are confi…
Browse files Browse the repository at this point in the history
…dent will stay and not change much.

Not promoting `--experimental_worker_multiplex` as I might want to change its syntax to allow specifying mnemonics, and that would be a breaking change.

PiperOrigin-RevId: 481879594
Change-Id: If91be6c675a219c5d46170c72f084c5693885c9b
  • Loading branch information
larsrc-google authored and copybara-github committed Oct 18, 2022
1 parent 17276d4 commit e38c73f
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 6 deletions.
6 changes: 3 additions & 3 deletions site/en/remote/dynamic.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ the Javac mnemonic only. The remote version works the same way. Both flags can
be specified multiple times. If an action cannot be executed locally, it is
executed remotely as normal, and vice-versa.

If your remote system has a cache, the `--experimental_local_execution_delay`
If your remote system has a cache, the `--ocal_execution_delay`

This comment has been minimized.

Copy link
@malkia

malkia Dec 20, 2022

Typo

This comment has been minimized.

Copy link
@larsrc-google

larsrc-google Dec 21, 2022

Author Contributor

Thanks for noticing, but I already fixed it.

flag adds a delay in milliseconds to the local execution after the remote system
has indicated a cache hit. This avoids running local execution when more cache
hits are likely. The default value is 1000ms, but should be tuned to being just
Expand Down Expand Up @@ -122,9 +122,9 @@ mnemonics, which would often lead to these kinds of problems.

Problems with dynamic execution can be subtle and hard to debug, as they can
manifest only under some specific combinations of local and remote execution.
The `--experimental_debug_spawn_scheduler` adds extra output from the dynamic
The `--debug_spawn_scheduler` adds extra output from the dynamic
execution system that can help debug these problems. You can also adjust the
`--experimental_local_execution_delay` flag and number of remote vs. local jobs
`--local_execution_delay` flag and number of remote vs. local jobs
to make it easier to reproduce the problems.

If you are experiencing problems with dynamic execution using the `standalone`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,9 @@ public class DynamicExecutionOptions extends OptionsBase {
public List<Map.Entry<String, List<String>>> dynamicRemoteStrategy;

@Option(
name = "experimental_local_execution_delay",
name = "dynamic_local_execution_delay",
oldName = "experimental_local_execution_delay",
oldNameWarning = false,
documentationCategory = OptionDocumentationCategory.EXECUTION_STRATEGY,
effectTags = {OptionEffectTag.EXECUTION, OptionEffectTag.HOST_MACHINE_RESOURCE_OPTIMIZATIONS},
defaultValue = "1000",
Expand All @@ -96,7 +98,9 @@ public class DynamicExecutionOptions extends OptionsBase {
public int localExecutionDelay;

@Option(
name = "experimental_debug_spawn_scheduler",
name = "debug_spawn_scheduler",
oldName = "experimental_debug_spawn_scheduler",
oldNameWarning = false,
documentationCategory = OptionDocumentationCategory.LOGGING,
effectTags = {OptionEffectTag.UNKNOWN},
defaultValue = "false")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ public String getTypeDescription() {
public List<Map.Entry<String, Integer>> workerMaxInstances;

@Option(
name = "experimental_worker_max_multiplex_instances",
name = "worker_max_multiplex_instances",
oldName = "experimental_worker_max_multiplex_instances",
oldNameWarning = false,
converter = MultiResourceConverter.class,
defaultValue = "null",
documentationCategory = OptionDocumentationCategory.EXECUTION_STRATEGY,
Expand Down

0 comments on commit e38c73f

Please sign in to comment.