Make the exec root name match the workspace name #1681
Assignees
Milestone
Comments
kchodorow
added
P2
bazel-io
pushed a commit
that referenced
this issue
Aug 25, 2016
Somewhat trickily, this changes the execRoot field from referring to [output_base]/execroot/wsname (not really the exec root) to [output_base]/execroot (actually the execroot). Progress on #1681. -- MOS_MIGRATED_REVID=131286181
bazel-io
pushed a commit
that referenced
this issue
Aug 26, 2016
…ory root The buildDataDirectory is calculated off of the incorrect execroot. More progress towards #1681. -- MOS_MIGRATED_REVID=131407798
kchodorow
added a commit
to kchodorow/buildifier
that referenced
this issue
Jan 25, 2017
This updates the go rules past bazelbuild/rules_go@5097c5b, which allows the go rules to work with bazel versions before and after the fix for bazelbuild/bazel#1681 goes in.
kchodorow
added a commit
to kchodorow/protobuf
that referenced
this issue
Jan 25, 2017
Bazel is changing the way the execution root is organized (see bazelbuild/bazel#1681 for details) and this updates the protobuf path logic to work with both old and new versions of Bazel.
pmbethe09
pushed a commit
to bazelbuild/buildtools
that referenced
this issue
Jan 25, 2017
This updates the go rules past bazelbuild/rules_go@5097c5b, which allows the go rules to work with bazel versions before and after the fix for bazelbuild/bazel#1681 goes in.
kchodorow
added a commit
to kchodorow/rules_closure
that referenced
this issue
Jan 25, 2017
When bazelbuild/bazel#1681 is submitted, external repositories' proto sources will no longer be under the execution root, they will be under ../repo_name. protoc needs to know which directories to look under, so this updates the genrule to include all repository paths in the protoc's search. This change should be backwards and forwards compatible, since protoc doesn't care if it gets extra search paths.
jart
pushed a commit
to bazelbuild/rules_closure
that referenced
this issue
Jan 28, 2017
When bazelbuild/bazel#1681 is submitted, external repositories' proto sources will no longer be under the execution root, they will be under ../repo_name. protoc needs to know which directories to look under, so this updates the genrule to include all repository paths in the protoc's search. This change should be backwards and forwards compatible, since protoc doesn't care if it gets extra search paths. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=145710427
kchodorow
added a commit
to kchodorow/skydoc
that referenced
this issue
Jan 31, 2017
Bazel's execroot structure is changing (see bazelbuild/bazel#1681) and the protobuf library needed to be updated to support the new structure. The change is forward/backward compatible.
kchodorow
added a commit
to kchodorow/rules_gwt
that referenced
this issue
Jan 31, 2017
I'm working on modifying the execution root path (see bazelbuild/bazel#1681) and, once that's in, the path relative to the execution root will be ../local_jdk (instead of external/jdk). This patch fixes the GWT rules to work with both old and new versions on Bazel.
kchodorow
added a commit
to kchodorow/rules_rust
that referenced
this issue
Jan 31, 2017
I'm working on updating the execution root structure (see bazelbuild/bazel#1681), which makes manually building the prefix unnecessary. I've left the strip_prefix("external/" code for backwards compatibility, but it should be able to be removed in the future.
kchodorow
added a commit
to kchodorow/rules_rust
that referenced
this issue
Jan 31, 2017
I'm working on updating the execution root structure (see bazelbuild/bazel#1681), which makes manually building the prefix unnecessary. I've left the strip_prefix("external/" code for backwards compatibility, but it should be able to be removed in the future.
kchodorow
added a commit
to kchodorow/rules_closure
that referenced
this issue
Feb 1, 2017
… directories This makes the js_module_root argument refer to the proper execution root directory regardless of bazel version used. Prep for bazelbuild/bazel#1681. Manually tested with old & new bazel versions.
kchodorow
added a commit
to kchodorow/rules_closure
that referenced
this issue
Feb 1, 2017
… directories This makes the js_module_root argument refer to the proper execution root directory regardless of bazel version used. Prep for bazelbuild/bazel#1681. Manually tested with old & new bazel versions.
This was referenced Feb 1, 2017
Closed
jart
pushed a commit
to bazelbuild/rules_closure
that referenced
this issue
Feb 1, 2017
… directories This makes the js_module_root argument refer to the proper execution root directory regardless of bazel version used. Prep for bazelbuild/bazel#1681. Manually tested with old & new bazel versions. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=146279859
kchodorow
added a commit
to bazelbuild/rules_rust
that referenced
this issue
Feb 8, 2017
…27) I'm working on updating the execution root structure (see bazelbuild/bazel#1681), which makes manually building the prefix unnecessary. I've left the strip_prefix("external/" code for backwards compatibility, but it should be able to be removed in the future.
kchodorow
added a commit
to bazelbuild/skydoc
that referenced
this issue
Feb 8, 2017
Bazel's execroot structure is changing (see bazelbuild/bazel#1681) and the protobuf library needed to be updated to support the new structure. The change is forward/backward compatible.
kchodorow
added a commit
to kchodorow/tensorflow
that referenced
this issue
Feb 9, 2017
I'm working on fixing bazelbuild/bazel#1681, which will change the way Bazel organizes the execution root. This has two implications for tensorflow: * The protobuf library needs to be updated to a version that works with old/new versions of Bazel (older versions won't be able to find external protos). * The curl library needs to use ../curl as an include prefix in new versions of Bazel and external/curl in old versions. This patch should be forward/backward compatible.
gunan
pushed a commit
to tensorflow/tensorflow
that referenced
this issue
Feb 11, 2017
I'm working on fixing bazelbuild/bazel#1681, which will change the way Bazel organizes the execution root. This has two implications for tensorflow: * The protobuf library needs to be updated to a version that works with old/new versions of Bazel (older versions won't be able to find external protos). * The curl library needs to use ../curl as an include prefix in new versions of Bazel and external/curl in old versions. This patch should be forward/backward compatible.
bazel-io
pushed a commit
that referenced
this issue
Mar 6, 2017
I was fixing the Android tests and I noticed that the bazel_workspace_status_test was failing. It was like when you have a thread coming out of a sweater and you start pulling and pretty soon you have no sweater. Long story short, my "Android tests fix" cl ended up needing ~1k more lines changed (on top of the existing enormous CL). So, I'm creating some smaller CLs with the changes that I can extract from the mega CL. Again. Prep for #1681. -- PiperOrigin-RevId: 149106039 MOS_MIGRATED_REVID=149106039
bazel-io
pushed a commit
that referenced
this issue
Apr 4, 2017
*** Reason for rollback *** Breaks //src/test/shell/integration:force_delete_output_test *** Original change description *** Symlink output directories to the correct directory name If the workspace directory is /path/to/my/proj and the name in the WORKSPACE file is "floop", this will symlink the output directories to output_base/execroot/floop instead of output_base/execroot/proj. More prep for #1262, fixes #1681. PiperOrigin-RevId: 152126545
This was referenced May 15, 2017
bazel-io
pushed a commit
that referenced
this issue
May 23, 2017
*** Reason for rollback *** Roll forward of directory name change *** Original change description *** Automated g4 rollback of commit 1d9e1ac. *** Reason for rollback *** Breaks //src/test/shell/integration:force_delete_output_test *** Original change description *** Symlink output directories to the correct directory name If the workspace directory is /path/to/my/proj and the name in the WORKSPACE file is "floop", this will symlink the output directories to output_base/execroot/floop instead of output_base/execroot/proj. More prep for #1262, fixes #1681. PiperOrigin-RevId: 156892980
Alaleh1191
pushed a commit
to epfl-vlsc/persona-system
that referenced
this issue
Jun 15, 2017
I'm working on fixing bazelbuild/bazel#1681, which will change the way Bazel organizes the execution root. This has two implications for tensorflow: * The protobuf library needs to be updated to a version that works with old/new versions of Bazel (older versions won't be able to find external protos). * The curl library needs to use ../curl as an include prefix in new versions of Bazel and external/curl in old versions. This patch should be forward/backward compatible.
lngart
pushed a commit
to lngart/GitSubSep
that referenced
this issue
Oct 5, 2021
I'm working on fixing bazelbuild/bazel#1681, which will change the way Bazel organizes the execution root. This has two implications for tensorflow: * The protobuf library needs to be updated to a version that works with old/new versions of Bazel (older versions won't be able to find external protos). * The curl library needs to use ../curl as an include prefix in new versions of Bazel and external/curl in old versions. This patch should be forward/backward compatible.
ptmphuong
pushed a commit
to ptmphuong/rules_closure
that referenced
this issue
Dec 9, 2022
When bazelbuild/bazel#1681 is submitted, external repositories' proto sources will no longer be under the execution root, they will be under ../repo_name. protoc needs to know which directories to look under, so this updates the genrule to include all repository paths in the protoc's search. This change should be backwards and forwards compatible, since protoc doesn't care if it gets extra search paths. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=145710427
ptmphuong
pushed a commit
to ptmphuong/rules_closure
that referenced
this issue
Dec 9, 2022
… directories This makes the js_module_root argument refer to the proper execution root directory regardless of bazel version used. Prep for bazelbuild/bazel#1681. Manually tested with old & new bazel versions. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=146279859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I swear I've filed this issue before but now I can't find it.
The execution root uses the basename of the workspace for the working directory (i.e., if you have
a/WORKSPACEthat definesworkspace(name = "b", then all actions run inexecroot/a). It should be able to pick up the exec root directory name after the loading phase, but right now it's set in BlazeDirectories on server startup, way before we know the workspace name.The text was updated successfully, but these errors were encountered: