Set output_files on proto_lang_toolchain rules
#18623
Assignees
Labels
P2
We'll consider working on this in future. (Assignee optional)
team-Rules-API
API for writing rules/aspects: providers, runfiles, actions, artifacts
Comments
comius
added
P2
copybara-service bot
pushed a commit
that referenced
this issue
Jun 9, 2023
Additional information is needed whether protoc generates a single file or multiple files. Add output_files to proto_lang_toolchain (enum "single","multiple") and propagate it through ProtoLangToolchainInfo. Add experimental_output_files to proto_common.compile, that can override the value, for faster migration path. When the value is set, automatically compute plugin_output. When the (legacy) plugin_output is not set to a file, set it automatically to correct directory. AI: Cherry-pick this change to Bazel minor release and follow up with updates to proto_lang_toolchain. Fixes: #18263 Tracking issue: #18623 PiperOrigin-RevId: 539047857 Change-Id: Id5c3f48f02ad245bee90eb113d5ba4f681c650ac
copybara-service bot
pushed a commit
that referenced
this issue
Jun 20, 2023
…_info NEW: don't try to compute plugin_output automatically Additional information is needed whether protoc generates a single file or multiple files. Add output_files to proto_lang_toolchain (enum "single","multiple") and propagate it through ProtoLangToolchainInfo. Add experimental_output_files to proto_common.compile, that can override the value, for faster migration path. When the value is set, automatically compute plugin_output. When the (legacy) plugin_output is not set to a file, set it automatically to correct directory. AI: Cherry-pick this change to Bazel minor release and follow up with updates to proto_lang_toolchain. Fixes: #18263 Tracking issue: #18623 PiperOrigin-RevId: 541964181 Change-Id: Ie4b4792287723798ffdd4047562d62eb05d1b731
traversaro
pushed a commit
to traversaro/bazel
that referenced
this issue
Jun 24, 2023
Additional information is needed whether protoc generates a single file or multiple files. Add output_files to proto_lang_toolchain (enum "single","multiple") and propagate it through ProtoLangToolchainInfo. Add experimental_output_files to proto_common.compile, that can override the value, for faster migration path. When the value is set, automatically compute plugin_output. When the (legacy) plugin_output is not set to a file, set it automatically to correct directory. AI: Cherry-pick this change to Bazel minor release and follow up with updates to proto_lang_toolchain. Fixes: bazelbuild#18263 Tracking issue: bazelbuild#18623 PiperOrigin-RevId: 539047857 Change-Id: Id5c3f48f02ad245bee90eb113d5ba4f681c650ac
comius
added a commit
to comius/bazel
that referenced
this issue
Jun 26, 2023
… from proto_info NEW: don't try to compute plugin_output automatically Additional information is needed whether protoc generates a single file or multiple files. Add output_files to proto_lang_toolchain (enum "single","multiple") and propagate it through ProtoLangToolchainInfo. Add experimental_output_files to proto_common.compile, that can override the value, for faster migration path. When the value is set, automatically compute plugin_output. When the (legacy) plugin_output is not set to a file, set it automatically to correct directory. AI: Cherry-pick this change to Bazel minor release and follow up with updates to proto_lang_toolchain. Fixes: bazelbuild#18263 Tracking issue: bazelbuild#18623 PiperOrigin-RevId: 541964181 Change-Id: Ie4b4792287723798ffdd4047562d62eb05d1b731
iancha1992
added a commit
that referenced
this issue
Jul 12, 2023
…d2be27ab… (#18773) * Rollforward of 482d2be: Compute the value of plugin_output from proto_info NEW: don't try to compute plugin_output automatically Additional information is needed whether protoc generates a single file or multiple files. Add output_files to proto_lang_toolchain (enum "single","multiple") and propagate it through ProtoLangToolchainInfo. Add experimental_output_files to proto_common.compile, that can override the value, for faster migration path. When the value is set, automatically compute plugin_output. When the (legacy) plugin_output is not set to a file, set it automatically to correct directory. AI: Cherry-pick this change to Bazel minor release and follow up with updates to proto_lang_toolchain. Fixes: #18263 Tracking issue: #18623 PiperOrigin-RevId: 541964181 Change-Id: Ie4b4792287723798ffdd4047562d62eb05d1b731 * Fix tests --------- Co-authored-by: Ian (Hee) Cha <heec@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With commit 482d2be and additional information on
proto_lang_toolchainrule,proto_common.compiledoesn't need to setplugin_outputparameter.proto_lang_toolchainrulesproto_common.compilecallsThe text was updated successfully, but these errors were encountered: