pdb_file not added to cc_shared_library output group

[peakschris]

Description of the bug:

When generate_pdb_file feature is enabled, the pdb_file is built. However, it is not added to the output group of cc_shared_library. The cc_binary rule seems to be ok.

The code in cc_binary that is missing from cc_shared library is:

bazel/src/main/starlark/builtins_bzl/common/cc/cc_binary.bzl

Lines 828 to 832 in d738910

	# If PDB file is generated by the link action, we add it to pdb_file output group
	if pdb_file != None:
	output_groups["pdb_file"] = depset([pdb_file])
	if generated_def_file != None:
	output_groups["def_file"] = depset([generated_def_file])

Which category does this issue belong to?

No response

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Trivial issue, but I can provide a git repo to reproduce this if it helps

Which operating system are you running Bazel on?

Windows

What is the output of bazel info release?

release 7.0.2

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.

No

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

The code in cc_binary that is missing from cc_shared library is:

bazel/src/main/starlark/builtins_bzl/common/cc/cc_binary.bzl

Lines 828 to 832 in d738910

	# If PDB file is generated by the link action, we add it to pdb_file output group
	if pdb_file != None:
	output_groups["pdb_file"] = depset([pdb_file])
	if generated_def_file != None:
	output_groups["def_file"] = depset([generated_def_file])

[fmeum]

Would you be interested in submitting a PR? You could add test coverage here:

bazel/src/main/starlark/tests/builtins_bzl/cc/cc_shared_library/test_cc_shared_library/starlark_tests.bzl

Line 405 in bb3414c

def _pdb_test_impl(env, target):

[peakschris]

fmeum, I would love to be able to contribute. Sadly my employer will not sign the google agreement, so I cannot contribute to this repo.

[iancha1992]

A fix for this issue has been included in Bazel 7.2.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.2.0rc1. Thanks!