Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pdb_file and def_file output groups to cc_shared_library #21900

Closed
wants to merge 3 commits into from
Closed

Add pdb_file and def_file output groups to cc_shared_library #21900

wants to merge 3 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Apr 4, 2024 •
edited
Loading

This matches cc_binary's behavior at

bazel/src/main/starlark/builtins_bzl/common/cc/cc_binary.bzl

Lines 828 to 832 in d738910

# If PDB file is generated by the link action, we add it to pdb_file output group
if pdb_file != None:
output_groups["pdb_file"] = depset([pdb_file])
if generated_def_file != None:
output_groups["def_file"] = depset([generated_def_file])

Fixes #21602

@fmeum fmeum marked this pull request as ready for review April 4, 2024 21:12
@fmeum fmeum requested a review from oquenchil April 4, 2024 21:12
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Apr 4, 2024
@sgowroji sgowroji added the team-Rules-CPP Issues for C++ rules label Apr 5, 2024
@oquenchil oquenchil requested review from pzembrod and removed request for oquenchil April 11, 2024 12:25
@pzembrod pzembrod added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 18, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 18, 2024

@bazel-io fork 7.2.0

@bazel-io bazel-io mentioned this pull request Apr 18, 2024
Closed
@fmeum fmeum deleted the 21602-pdb branch April 19, 2024 10:16
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 26, 2024
@keertk
Copy link
Member

keertk commented May 9, 2024

Hi all, is this still needed for 7.2?
If so, could you please send a PR to cherry-pick? We're aiming to have the first RC out on Monday 5/13.

fmeum added a commit to fmeum/bazel that referenced this pull request May 10, 2024
@fmeum
Add pdb_file and def_file output groups to cc_shared_library
74ea826 
This matches `cc_binary`'s behavior at https://github.com/bazelbuild/bazel/blob/d738910e83427d394526cbdfc8ac665027dd9196/src/main/starlark/builtins_bzl/common/cc/cc_binary.bzl#L828-L832

Fixes bazelbuild#21602

Closes bazelbuild#21900.

PiperOrigin-RevId: 626309605
Change-Id: I58683eaa2eedd590746e51df8c97833527c409f4
Kila2 pushed a commit to Kila2/bazel that referenced this pull request May 13, 2024
@fmeum @Kila2
Add pdb_file and def_file output groups to cc_shared_library
f5bc1b0 
This matches `cc_binary`'s behavior at https://github.com/bazelbuild/bazel/blob/d738910e83427d394526cbdfc8ac665027dd9196/src/main/starlark/builtins_bzl/common/cc/cc_binary.bzl#L828-L832

Fixes bazelbuild#21602

Closes bazelbuild#21900.

PiperOrigin-RevId: 626309605
Change-Id: I58683eaa2eedd590746e51df8c97833527c409f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzembrod pzembrod pzembrod approved these changes

Assignees
No one assigned
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pdb_file not added to cc_shared_library output group
4 participants
@fmeum @keertk @pzembrod @sgowroji