Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: break the dependency on Bash #4319

Closed
laszlocsomor opened this issue Dec 18, 2017 · 6 comments
Closed

Windows: break the dependency on Bash #4319

laszlocsomor opened this issue Dec 18, 2017 · 6 comments
Assignees
@laszlocsomor
Labels
area-Windows Windows-specific issues and feature requests P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: feature request

Comments

@laszlocsomor
Copy link
Contributor

Bazel should not require the presence of Bash, nor the presence of the BAZEL_SH envvar.

Bash should be just another tool(chain) like Python.
@laszlocsomor laszlocsomor self-assigned this Dec 18, 2017
@laszlocsomor laszlocsomor mentioned this issue Mar 28, 2018
Closed
@laszlocsomor
Copy link
Contributor Author

Design doc: https://docs.google.com/document/d/e/2PACX-1vRCSB_n3vctL6bKiPkIa_RN_ybzoAccSe0ic8mxdFNZGNBJ3QGhcKjsL7YKf-ngVyjRZwCmhi_5KhcX/pub

laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 9, 2018
@laszlocsomor
bash: Add a toolchain for local Bash.
2ec0250 
Bazel automatically detects the local Bash and
creates a custom toolchain rule for it.

Later, rules that use Bash will require this
toolchain and retrieve Bash's path from it instead
of relying on hardcoded paths or the
--shell_executable flag.

See bazelbuild#4319

Change-Id: Idd8242a20d202b1f5a56cddac95b625c6c08ede9
@laszlocsomor laszlocsomor mentioned this issue Apr 9, 2018
Closed
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 12, 2018
@laszlocsomor
bash: Add a toolchain for local Bash.
d4fe1af 
Bazel automatically detects the local Bash and
creates a custom toolchain rule for it.

Later, rules that use Bash will require this
toolchain and retrieve Bash's path from it instead
of relying on hardcoded paths or the
--shell_executable flag.

See bazelbuild#4319

Change-Id: Idd8242a20d202b1f5a56cddac95b625c6c08ede9
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 12, 2018
@laszlocsomor
bash: Add a toolchain for local Bash.
e70e16b 
Bazel automatically detects the local Bash and
creates a custom toolchain rule for it.

Later, rules that use Bash will require this
toolchain and retrieve Bash's path from it instead
of relying on hardcoded paths or the
--shell_executable flag.

See bazelbuild#4319

Change-Id: Idd8242a20d202b1f5a56cddac95b625c6c08ede9
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 12, 2018
@laszlocsomor
bash: Add a toolchain for local Bash.
73a3b36 
Bazel automatically detects the local Bash and
creates a custom toolchain rule for it.

Later, rules that use Bash will require this
toolchain and retrieve Bash's path from it instead
of relying on hardcoded paths or the
--shell_executable flag.

See bazelbuild#4319

Change-Id: Idd8242a20d202b1f5a56cddac95b625c6c08ede9
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 12, 2018
@laszlocsomor
bash: Add a toolchain for local Bash.
64b3270 
Bazel automatically detects the local Bash and
creates a custom toolchain rule for it.

Later, rules that use Bash will require this
toolchain and retrieve Bash's path from it instead
of relying on hardcoded paths or the
--shell_executable flag.

See bazelbuild#4319

Change-Id: Idd8242a20d202b1f5a56cddac95b625c6c08ede9
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 13, 2018
@laszlocsomor
bash: Add a toolchain for local Bash.
dc5f7ff 
Bazel automatically detects the local Bash and
creates a custom toolchain rule for it.

Later, rules that use Bash will require this
toolchain and retrieve Bash's path from it instead
of relying on hardcoded paths or the
--shell_executable flag.

See bazelbuild#4319

Change-Id: Idd8242a20d202b1f5a56cddac95b625c6c08ede9
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 13, 2018
@laszlocsomor
bash: Add a toolchain for local Bash.
b8fd0e7 
Bazel automatically detects the local Bash and
creates a custom toolchain rule for it.

Later, rules that use Bash will require this
toolchain and retrieve Bash's path from it instead
of relying on hardcoded paths or the
--shell_executable flag.

See bazelbuild#4319

Change-Id: Idd8242a20d202b1f5a56cddac95b625c6c08ede9
bazel-io pushed a commit that referenced this issue Apr 16, 2018
@laszlocsomor
bash: Add a toolchain for local Bash.
81ed3ad 
Bazel automatically detects the local Bash and
creates a custom toolchain rule for it.

Later, rules that use Bash will require this
toolchain and retrieve Bash's path from it instead
of relying on hardcoded paths or the
`--shell_executable` flag.

See #4319

Change-Id: Idd8242a20d202b1f5a56cddac95b625c6c08ede9

Closes #4980.

Change-Id: Ic2406a4da260b284e15852070d58472ca18340af
PiperOrigin-RevId: 193022708
This was referenced Apr 17, 2018
Closed
Closed
bazel-io pushed a commit that referenced this issue Apr 23, 2018
@laszlocsomor
SpawnAction.setShellCommand: expect shell path
84d3097 
SpawnAction.setShellCommand(String) now expects
the shell interpreter's path as an argument. This
change enables two things:
- rules can report an error if the shell is
  missing
- SpawnAction no longer has to know about a
  default shell

The new ShToolchain class will later also be
responsible for retrieving the active shell
toolchain (added in 81ed3ad).

This change brings Bazel closer to not depend on
the shell unless it has to (e.g. to run shell
scripts).

See #4319

RELNOTES: none
PiperOrigin-RevId: 193885943
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 23, 2018
@laszlocsomor
windows,client: fix error reporting
af8de46 
Fix error reporting in the path conversion methods
of the Bazel client. Previously the error
reporting logic used GetLastErrorString in places
where it was not appropriate (i.e. it was not a
failed Windows API call that caused an error).

This cleanup prepares removing the concept of the
MSYS root from the Bazel client, since MSYS paths
are no longer supported and we want to cut Bazel's
dependency on Bash (thus MSYS) completely.

See bazelbuild#4319

Change-Id: Ie50a20e0ee0c572592f637340a2f2948c7f53088
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 23, 2018
@laszlocsomor
windows,client: fix error reporting
a93edc5 
Fix error reporting in the path conversion methods
of the Bazel client. Previously the error
reporting logic used GetLastErrorString in places
where it was not appropriate (i.e. it was not a
failed Windows API call that caused an error).

This cleanup prepares removing the concept of the
MSYS root from the Bazel client, since MSYS paths
are no longer supported and we want to cut Bazel's
dependency on Bash (thus MSYS) completely.

See bazelbuild#4319

Change-Id: Ie50a20e0ee0c572592f637340a2f2948c7f53088
@laszlocsomor laszlocsomor mentioned this issue Apr 23, 2018
Closed
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 23, 2018
@laszlocsomor
windows,client: fix error reporting
e1212ba 
Fix error reporting in the path conversion methods
of the Bazel client. Previously the error
reporting logic used GetLastErrorString in places
where it was not appropriate (i.e. it was not a
failed Windows API call that caused an error).

This cleanup prepares removing the concept of the
MSYS root from the Bazel client, since MSYS paths
are no longer supported and we want to cut Bazel's
dependency on Bash (thus MSYS) completely.

See bazelbuild#4319

Change-Id: Ie50a20e0ee0c572592f637340a2f2948c7f53088
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 23, 2018
@laszlocsomor
windows,client: fix error reporting
88b957a 
Fix error reporting in the path conversion methods
of the Bazel client. Previously the error
reporting logic used GetLastErrorString in places
where it was not appropriate (i.e. it was not a
failed Windows API call that caused an error).

This cleanup prepares removing the concept of the
MSYS root from the Bazel client, since MSYS paths
are no longer supported and we want to cut Bazel's
dependency on Bash (thus MSYS) completely.

See bazelbuild#4319

Change-Id: Ie50a20e0ee0c572592f637340a2f2948c7f53088
bazel-io pushed a commit that referenced this issue Apr 24, 2018
@laszlocsomor
windows,client: fix error reporting
8c400c8 
Fix error reporting in the path conversion methods
of the Bazel client. Previously the error
reporting logic used GetLastErrorString in places
where it was not appropriate (i.e. it was not a
failed Windows API call that caused an error).

This cleanup prepares removing the concept of the
MSYS root from the Bazel client, since MSYS paths
are no longer supported and we want to cut Bazel's
dependency on Bash (thus MSYS) completely.

See #4319

Change-Id: Ie50a20e0ee0c572592f637340a2f2948c7f53088

Closes #5072.

Change-Id: Ie50a20e0ee0c572592f637340a2f2948c7f53088
PiperOrigin-RevId: 194052665
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 25, 2018
@laszlocsomor
windows,client: no longer support Unix-style paths
6f1efca 
The Bazel client no longer supports MSYS paths.
The only exception is "/dev/null" which the client
treats as "NUL".

After this change you can no longer pass MSYS
paths as Bazel flag values on Windows.

See bazelbuild#4319

Change-Id: I39d81843015c5a4014dd5953bac2e1c29dcd5bed
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 25, 2018
@laszlocsomor
windows,client: no longer support Unix-style paths
8bcf566 
The Bazel client no longer supports MSYS paths.
The only exception is "/dev/null" which the client
treats as "NUL".

After this change you can no longer pass MSYS
paths as Bazel flag values on Windows.

See bazelbuild#4319

Change-Id: I39d81843015c5a4014dd5953bac2e1c29dcd5bed
bazel-io pushed a commit that referenced this issue Apr 26, 2018
@laszlocsomor
windows,client: no longer support Unix-style paths
9f3825f 
The Bazel client no longer supports MSYS paths.
The only exception is "/dev/null" which the client
treats as "NUL".

After this change you can no longer pass MSYS
paths as Bazel flag values on Windows.

See #4319

Change-Id: I39d81843015c5a4014dd5953bac2e1c29dcd5bed
PiperOrigin-RevId: 194372504
@laszlocsomor laszlocsomor mentioned this issue May 3, 2018
Closed
laszlocsomor added a commit to laszlocsomor/bazel-skylib that referenced this issue Mar 25, 2019
@laszlocsomor
diff_test: add rule and tests
0e2ff4e 
This PR adds a new rule: diff_test().

The test rule compares the contents of two files.
The 'diff_test.expect_same' attribute tells
whether the files are expected to be the same or
not.

The test succeeds if the files are the same and
expected to be so, or if the files are different
and expected to be so. Otherwise the test fails.

This rules requires no Bash on Windows, so it
works without Bash, without /usr/bin/diff, and
with the Windows-native test wrapper.

See bazelbuild/bazel#5508
See bazelbuild/bazel#4319
laszlocsomor added a commit to laszlocsomor/bazel-skylib that referenced this issue Mar 25, 2019
@laszlocsomor
diff_test: add rule and tests
1aa08fe 
This PR adds a new rule: diff_test().

The test rule compares the contents of two files.
The 'diff_test.expect_same' attribute tells
whether the files are expected to be the same or
not.

The test succeeds if the files are the same and
expected to be so, or if the files are different
and expected to be so. Otherwise the test fails.

This rules requires no Bash on Windows, so it
works without Bash, without /usr/bin/diff, and
with the Windows-native test wrapper.

See bazelbuild/bazel#5508
See bazelbuild/bazel#4319
laszlocsomor added a commit to laszlocsomor/bazel-skylib that referenced this issue Mar 25, 2019
@laszlocsomor
diff_test: add rule and tests
a4f0447 
This PR adds a new rule: diff_test().

The test rule compares the contents of two files.
The 'diff_test.expect_same' attribute tells
whether the files are expected to be the same or
not.

The test succeeds if the files are the same and
expected to be so, or if the files are different
and expected to be so. Otherwise the test fails.

This rules requires no Bash on Windows, so it
works without Bash, without /usr/bin/diff, and
with the Windows-native test wrapper.

See bazelbuild/bazel#5508
See bazelbuild/bazel#4319
@laszlocsomor laszlocsomor mentioned this issue Mar 25, 2019
Merged
laszlocsomor added a commit to laszlocsomor/bazel-skylib that referenced this issue Apr 9, 2019
@laszlocsomor
diff_test: add rule and tests
9bfa958 
This new test rule compares two files and passes
if the files match.

On Linux/macOS/non-Windows, the test compares
files using 'diff'.

On Windows, the test compares files using
'fc.exe'. This utility is available on all Windows
versions I tried (Windows 2008 Server, Windows
2016 Datacenter Core).

See bazelbuild/bazel#5508
See bazelbuild/bazel#4319
c-parsons pushed a commit to bazelbuild/bazel-skylib that referenced this issue Apr 12, 2019
@laszlocsomor @c-parsons
diff_test: add rule and tests (#136)
be3b1fc 
This new test rule compares two files and passes
if the files match.

On Linux/macOS/non-Windows, the test compares
files using 'diff'.

On Windows, the test compares files using
'fc.exe'. This utility is available on all Windows
versions I tried (Windows 2008 Server, Windows
2016 Datacenter Core).

See bazelbuild/bazel#5508
See bazelbuild/bazel#4319
@aherrmann aherrmann mentioned this issue Apr 24, 2019
Closed
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 26, 2019
@laszlocsomor
Windows, testing: only look up shell if needed
89b16b2 
TestActionBuilder now only looks up the shell (via
ShToolchain.getPathOrError) when the shell is
required.

Now, when using the Windows-native test wrapper
with --shell_toolchain="" (and without a
shell-command-looking --run_under argument) the
TestActionBuilder won't depend on Bash.

Related: bazelbuild#4319
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 26, 2019
@laszlocsomor
Windows, testing: only look up shell if needed
36c3a0e 
TestActionBuilder now only looks up the shell (via
ShToolchain.getPathOrError) when the shell is
required.

Now, when using the Windows-native test wrapper
with --shell_toolchain="" (and without a
shell-command-looking --run_under argument) the
TestActionBuilder won't depend on Bash.

Related: bazelbuild#4319
@laszlocsomor laszlocsomor mentioned this issue Apr 26, 2019
Closed
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 26, 2019
@laszlocsomor
Windows, testing: only look up shell if needed
9181016 
TestActionBuilder now only looks up the shell (via
ShToolchain.getPathOrError) when the shell is
required.

Now, when using the Windows-native test wrapper
with --shell_toolchain="" (and without a
shell-command-looking --run_under argument) the
TestActionBuilder won't depend on Bash.

Related: bazelbuild#4319
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 26, 2019
@laszlocsomor
Windows, testing: replace sh_tests with Starlark
a7202d2 
test_wrapper_test asserts that Bazel can run tests
with the Windows-native test wrapper, i.e. without
Bash. Yet test_wrapper_test itself required Bash
for its mock sh_test rules.

This PR replaces those sh_test rules with simple
Starlark test rules.

Related: bazelbuild#4319
@laszlocsomor laszlocsomor mentioned this issue Apr 26, 2019
Closed
bazel-io pushed a commit that referenced this issue Apr 29, 2019
@laszlocsomor
Windows, testing: replace sh_tests with Starlark
74bf788 
test_wrapper_test asserts that Bazel can run tests
with the Windows-native test wrapper, i.e. without
Bash. Yet test_wrapper_test itself required Bash
for its mock sh_test rules.

This PR replaces those sh_test rules with simple
Starlark test rules.

Related: #4319

Closes #8165.

Change-Id: I6a3d6641d0998f5a7f02def61902e3fb8187e0c9
PiperOrigin-RevId: 245688126
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 30, 2019
@laszlocsomor
Windows, testing: only look up shell if needed
63c3343 
TestActionBuilder now only looks up the shell (via
ShToolchain.getPathOrError) when the shell is
required.

Now, when using the Windows-native test wrapper
with --shell_toolchain="" (and without a
shell-command-looking --run_under argument) the
TestActionBuilder won't depend on Bash.

Related: bazelbuild#4319
bazel-io pushed a commit that referenced this issue May 2, 2019
@laszlocsomor
Windows, testing: only look up shell if needed
6b08ff1 
TestActionBuilder now only looks up the shell (via
ShToolchain.getPathOrError) when the shell is
required.

Now, when using the Windows-native test wrapper
with --shell_toolchain="" (and without a
shell-command-looking --run_under argument) the
TestActionBuilder won't depend on Bash.

Related: #4319

Closes #8161.

PiperOrigin-RevId: 246275913
@laszlocsomor laszlocsomor mentioned this issue May 3, 2019
Closed
@meteorcloudy meteorcloudy mentioned this issue May 14, 2019
Closed
@laszlocsomor
Copy link
Contributor Author

Status:

@laszlocsomor
Copy link
Contributor Author

Bazel 1.0 is released, and both #6622 and #8229 made it into the release.

@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
This was referenced Jun 6, 2021
Open
Open
Open
Open
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
CommandHelper: do not look up shell's path
a18a237 
    The CommandHelper no longer looks up the shell
    interpreter's path itself. Instead its ctor takes
    the path as an argument.

    This change will allow incrementally migrating
    rules that use CommandHelper to start depending on
    the shell toolchain.

    Shell-using rules today only use the
    ShellConfiguration config fragment to look up the
    shell's path. In the future, more and more rules
    will also retrieve the active shell toolchain, and
    be able to:

    1. use the auto-detected local shell interpreter's
       location, especially when it's not the default
       /bin/bash

    2. use define different shell toolchains
      (different interpreter paths) for remote builds

    3. gracefully fail the build if the machine has no
       shell installed but the action graph included a
       shell action

    See bazelbuild/bazel#4319

    Change-Id: I4da4e77e7d1fe57e8e4f5eb8820d03a840915e20

    Closes #5283.

    Change-Id: I4da4e77e7d1fe57e8e4f5eb8820d03a840915e20
    PiperOrigin-RevId: 198298315
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
SpawnAction.setShellCommand: expect shell path
58a8e19 
    SpawnAction.setShellCommand(String) now expects
    the shell interpreter's path as an argument. This
    change enables two things:
    - rules can report an error if the shell is
      missing
    - SpawnAction no longer has to know about a
      default shell

    The new ShToolchain class will later also be
    responsible for retrieving the active shell
    toolchain (added in bazelbuild/bazel@81ed3ad).

    This change brings Bazel closer to not depend on
    the shell unless it has to (e.g. to run shell
    scripts).

    See bazelbuild/bazel#4319

    RELNOTES: none
    PiperOrigin-RevId: 193885943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laszlocsomor laszlocsomor

Labels
area-Windows Windows-specific issues and feature requests P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@philwo @EdSchouten @buchgr @aiuto @laszlocsomor